From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG Date: Mon, 1 Jun 2015 11:22:49 +0200 Message-ID: <20150601092249.GF17267@lukather> References: <1433088626-8858-1-git-send-email-hdegoede@redhat.com> <1433088626-8858-2-git-send-email-hdegoede@redhat.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="V4b9U9vrdWczvw78" Return-path: Content-Disposition: inline In-Reply-To: <1433088626-8858-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Hans de Goede Cc: Felipe Balbi , Kishon Vijay Abraham I , Chen-Yu Tsai , Roman Byshko , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --V4b9U9vrdWczvw78 Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Sun, May 31, 2015 at 06:10:25PM +0200, Hans de Goede wrote: > + /* We either want both gpio pins or neither (when in host mode) */ > + if (!data->id_det_gpio != !data->vbus_det_gpio) { > + dev_err(dev, "failed to get id or vbus detect pin\n"); > + return -ENODEV; > + } The fact that the driver expects both to be set if one is should be in the binding documentation. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --V4b9U9vrdWczvw78-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Mon, 1 Jun 2015 11:22:49 +0200 Subject: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG In-Reply-To: <1433088626-8858-2-git-send-email-hdegoede@redhat.com> References: <1433088626-8858-1-git-send-email-hdegoede@redhat.com> <1433088626-8858-2-git-send-email-hdegoede@redhat.com> Message-ID: <20150601092249.GF17267@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, May 31, 2015 at 06:10:25PM +0200, Hans de Goede wrote: > + /* We either want both gpio pins or neither (when in host mode) */ > + if (!data->id_det_gpio != !data->vbus_det_gpio) { > + dev_err(dev, "failed to get id or vbus detect pin\n"); > + return -ENODEV; > + } The fact that the driver expects both to be set if one is should be in the binding documentation. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: