From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzNSI-0002ZM-Mc for qemu-devel@nongnu.org; Mon, 01 Jun 2015 07:00:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzNSF-00016Y-Fp for qemu-devel@nongnu.org; Mon, 01 Jun 2015 07:00:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35518) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzNSF-00016S-9k for qemu-devel@nongnu.org; Mon, 01 Jun 2015 07:00:27 -0400 Date: Mon, 1 Jun 2015 13:00:22 +0200 From: "Michael S. Tsirkin" Message-ID: <20150601130002-mutt-send-email-mst@redhat.com> References: <1430320913-20737-1-git-send-email-somlo@cmu.edu> <1430320913-20737-5-git-send-email-somlo@cmu.edu> <20150531181048.GC5268@redhat.com> <556C046B.9070704@redhat.com> <20150601092645-mutt-send-email-mst@redhat.com> <556C1F63.1090605@redhat.com> <20150601121908-mutt-send-email-mst@redhat.com> <556C3757.7080603@redhat.com> <20150601124604-mutt-send-email-mst@redhat.com> <556C390A.7090706@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <556C390A.7090706@redhat.com> Subject: Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: matt.fleming@intel.com, "Gabriel L. Somlo" , qemu-devel@nongnu.org, gsomlo@gmail.com, kraxel@redhat.com, Laszlo Ersek On Mon, Jun 01, 2015 at 12:50:50PM +0200, Paolo Bonzini wrote: > > > On 01/06/2015 12:48, Michael S. Tsirkin wrote: > > On Mon, Jun 01, 2015 at 12:43:35PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 01/06/2015 12:23, Michael S. Tsirkin wrote: > >>> Still, reserving part of the namespace for QEMU internal use > >>> is *not* policy, it's just good engineering. > >>> > >>> How about we forbid adding files under "etc/" ? > >>> > >>> That would be enough to avoid conflicts. > >> > >> I do not understand. What we're doing is free-beer. We can always say > >> no. What's your worry? > > > > Someone writes a tool using a specific path. > > We then add same path upstream, script breaks. > > Who cares. We documented it. > > >> One usecase of this feature is to avoid recompiling QEMU while playing > >> with firmware. If you cannot mimic QEMU's behavior (which is to add > >> "etc/" files), the feature is pointless, or at least I totally cannot > >> understand its purpose and I'm against merging it. > > > > Confused. Why does it produce the warning then? > > Because someone else asked for it. I cannot answer. :) > > > If it's just for playing games, add a configure > > switch to enable it, and disable by default. > > Don't set traps for users. > > What is for playing games? What is the feature useful for, except for > developers. > > Paolo OK so if it's a dveloper feature, I think a config flag to hide it from users is a good idea?