From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751511AbbFAOK7 (ORCPT ); Mon, 1 Jun 2015 10:10:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52100 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751540AbbFAOKv (ORCPT ); Mon, 1 Jun 2015 10:10:51 -0400 Date: Mon, 1 Jun 2015 16:10:46 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, namhyung@kernel.org, eranian@google.com, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 05/11] perf, tools, report: Add processing for cycle histograms Message-ID: <20150601141046.GA14379@krava.redhat.com> References: <1432749114-904-1-git-send-email-andi@firstfloor.org> <1432749114-904-6-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432749114-904-6-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2015 at 10:51:48AM -0700, Andi Kleen wrote: SNIP > +void hist__account_cycles(struct branch_stack *bs, struct addr_location *al, > + struct perf_sample *sample, bool nonany_branch_mode) > +{ > + struct branch_info *bi; > + > + /* If we have branch cycles always annotate them. */ > + if (bs && bs->nr && bs->entries[0].flags.cycles) { > + int i; > + > + bi = sample__resolve_bstack(sample, al); > + if (bi) { > + struct addr_map_symbol *prev = NULL; > + > + /* > + * Ignore errors, still want to process the > + * other entries. > + * > + * For non standard branch modes always > + * force no IPC (prev == NULL) > + * > + * Note that perf stores branches reversed from > + * program order! > + */ > + for (i = bs->nr - 1; i >= 0; i--) { > + addr_map_symbol__account_cycles(&bi[i].from, > + nonany_branch_mode ? NULL : prev, > + bi[i].flags.cycles); it's only ERANGE you want to ignore here jirka