From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753312AbbFAOTw (ORCPT ); Mon, 1 Jun 2015 10:19:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39973 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752165AbbFAOTq (ORCPT ); Mon, 1 Jun 2015 10:19:46 -0400 Date: Mon, 1 Jun 2015 16:19:41 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, namhyung@kernel.org, eranian@google.com, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 04/11] perf, tools, report: Add infrastructure for a cycles histogram Message-ID: <20150601141941.GA14991@krava.redhat.com> References: <1432749114-904-1-git-send-email-andi@firstfloor.org> <1432749114-904-5-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432749114-904-5-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2015 at 10:51:47AM -0700, Andi Kleen wrote: > From: Andi Kleen > > This adds the basic infrastructure to keep track of cycle counts > per basic block for annotate. We allocate an array similar to the > normal accounting, and then account branch cycles there. > > We handle two cases: > cycles per basic block with start and cycles per branch > (these are later used for either IPC or just cycles per BB) > > In the start case we cannot handle overlaps, so always the longest > basic block wins. > > For the cycles per branch case everything is accurately accounted. > > v2: Remove unnecessary checks. Slight restructure. Move > symbol__get_annotation to another patch. Move histogram allocation. > Signed-off-by: Andi Kleen Acked-by: Jiri Olsa thanks, jirka