From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753324AbbFAOV5 (ORCPT ); Mon, 1 Jun 2015 10:21:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45248 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752031AbbFAOVl (ORCPT ); Mon, 1 Jun 2015 10:21:41 -0400 Date: Mon, 1 Jun 2015 16:21:36 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, namhyung@kernel.org, eranian@google.com, linux-kernel@vger.kernel.org Subject: Re: Cycles annotation support for perf tools v2 Message-ID: <20150601142136.GB14379@krava.redhat.com> References: <1432749114-904-1-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432749114-904-1-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2015 at 10:51:43AM -0700, Andi Kleen wrote: > [v2: Addressed review comments. Fixed display problems and > correctly compute IPC now. See patches for detailed changes.] > > The upcoming Skylake CPU has a new timed branch stack feature, > that reports cycle counts for individual branches in the > last branch record. > > This allows to get fine grained cost information for code, and also allows > to compute fine grained IPC. > > Available from > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git perf/skl-tools2 > > This patchkit adds support for this in the perf tools: > - Basic support for the cycles field like other branch fields > - Show cycles in the standard branch sort view (no IPC here, > as IPC needs the instruction counts from annotation) > - Annotate cycles and IPC in the assembler annotate view > - Add branch support to top, so we can do live annotation. > - Misc support, like dumping it in perf report -D v2 seems ok to me.. all my comments were addressed, and I posted one more comment anyway, I dont touch annotate code that much to ack annotate core patches.. acking only portion of the patchset thanks, jirka