From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzOzI-0007bu-5Q for qemu-devel@nongnu.org; Mon, 01 Jun 2015 08:38:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzOzC-0006Hh-QU for qemu-devel@nongnu.org; Mon, 01 Jun 2015 08:38:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzOzC-0006HW-L5 for qemu-devel@nongnu.org; Mon, 01 Jun 2015 08:38:34 -0400 Date: Mon, 1 Jun 2015 14:38:30 +0200 From: "Michael S. Tsirkin" Message-ID: <20150601143447-mutt-send-email-mst@redhat.com> References: <1430320913-20737-1-git-send-email-somlo@cmu.edu> <1430320913-20737-5-git-send-email-somlo@cmu.edu> <20150531181048.GC5268@redhat.com> <556C046B.9070704@redhat.com> <20150601092645-mutt-send-email-mst@redhat.com> <556C1F63.1090605@redhat.com> <20150601121908-mutt-send-email-mst@redhat.com> <556C3757.7080603@redhat.com> <20150601124604-mutt-send-email-mst@redhat.com> <556C417D.4050707@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <556C417D.4050707@redhat.com> Subject: Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: matt.fleming@intel.com, "Gabriel L. Somlo" , qemu-devel@nongnu.org, gsomlo@gmail.com, kraxel@redhat.com, Paolo Bonzini On Mon, Jun 01, 2015 at 01:26:53PM +0200, Laszlo Ersek wrote: > On 06/01/15 12:48, Michael S. Tsirkin wrote: > > On Mon, Jun 01, 2015 at 12:43:35PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 01/06/2015 12:23, Michael S. Tsirkin wrote: > >>> Still, reserving part of the namespace for QEMU internal use > >>> is *not* policy, it's just good engineering. > >>> > >>> How about we forbid adding files under "etc/" ? > >>> > >>> That would be enough to avoid conflicts. > >> > >> I do not understand. What we're doing is free-beer. We can always say > >> no. What's your worry? > > > > Someone writes a tool using a specific path. > > We then add same path upstream, script breaks. > > > >> One usecase of this feature is to avoid recompiling QEMU while playing > >> with firmware. If you cannot mimic QEMU's behavior (which is to add > >> "etc/" files), the feature is pointless, or at least I totally cannot > >> understand its purpose and I'm against merging it. > >> > >> Paolo > > > > Confused. Why does it produce the warning then? > > > > If it's just for playing games, add a configure > > switch to enable it, and disable by default. > > Don't set traps for users. > > The site specific feature can be long-term for a given site. It might > live across several QEMU upgrades. New version of QEMU introdces a new > fw_cfg file, might conflict with user's file from earlier. Unless the > user places it under opt/. For that reason we emit a warning, but do not > forcefully prevent the user from shooting his foot off. > > Laszlo I'm sorry - I don't understand. It's easy to do the right thing. Just add the opt prefix. Why insist on user doing the right thing, and punish violations with failing at random? If it's useful for developers somehow, add a config flag for that. -- MST