From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752929AbbFAOoN (ORCPT ); Mon, 1 Jun 2015 10:44:13 -0400 Received: from mail.kernel.org ([198.145.29.136]:43586 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752033AbbFAOoC (ORCPT ); Mon, 1 Jun 2015 10:44:02 -0400 Date: Mon, 1 Jun 2015 11:43:58 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Andi Kleen , namhyung@kernel.org, eranian@google.com, linux-kernel@vger.kernel.org Subject: Re: Cycles annotation support for perf tools v2 Message-ID: <20150601144358.GJ624@kernel.org> References: <1432749114-904-1-git-send-email-andi@firstfloor.org> <20150601142136.GB14379@krava.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150601142136.GB14379@krava.redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Jun 01, 2015 at 04:21:36PM +0200, Jiri Olsa escreveu: > On Wed, May 27, 2015 at 10:51:43AM -0700, Andi Kleen wrote: > > [v2: Addressed review comments. Fixed display problems and > > correctly compute IPC now. See patches for detailed changes.] > > > > The upcoming Skylake CPU has a new timed branch stack feature, > > that reports cycle counts for individual branches in the > > last branch record. > > > > This allows to get fine grained cost information for code, and also allows > > to compute fine grained IPC. > > > > Available from > > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git perf/skl-tools2 > > > > This patchkit adds support for this in the perf tools: > > - Basic support for the cycles field like other branch fields > > - Show cycles in the standard branch sort view (no IPC here, > > as IPC needs the instruction counts from annotation) > > - Annotate cycles and IPC in the assembler annotate view > > - Add branch support to top, so we can do live annotation. > > - Misc support, like dumping it in perf report -D > > v2 seems ok to me.. all my comments were addressed, > and I posted one more comment > > anyway, I dont touch annotate code that much to ack annotate > core patches.. acking only portion of the patchset I took and pushed two of those patches already, will try to look at the annotation bits later today... - Arnaldo