From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754806AbbFBFVs (ORCPT ); Tue, 2 Jun 2015 01:21:48 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55398 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542AbbFBFVk (ORCPT ); Tue, 2 Jun 2015 01:21:40 -0400 Date: Tue, 2 Jun 2015 14:21:37 +0900 From: Greg KH To: pmarzo Cc: navyasri.tech@gmail.com, dilekuzulmez@gmail.com, joe@perches.com, haticeerturk27@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3 v4] Staging: rtl8192u: Remove two useless lines at ieee80211_wep_null Message-ID: <20150602052137.GA22211@kroah.com> References: <1432167919-26298-1-git-send-email-marzo.pedro@gmail.com> <1432167919-26298-3-git-send-email-marzo.pedro@gmail.com> <20150531013900.GF28154@kroah.com> <1433197152.3615.4.camel@pedrito-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433197152.3615.4.camel@pedrito-laptop> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 02, 2015 at 12:19:12AM +0200, pmarzo wrote: > On Sun, 2015-05-31 at 10:39 +0900, Greg KH wrote: > > On Thu, May 21, 2015 at 02:25:18AM +0200, Pedro Marzo Perez wrote: > > > Remove two lines at ieee80211_wep_null which checkpatch.pl reported as errors. > > > The first one because it has a C99 comment style and the second one because it is a void > > > return which is useless. > > > > > > Signed-off-by: Pedro Marzo Perez > > > --- > > > drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > > > index bd789d1..94622cc 100644 > > > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > > > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > > > @@ -279,6 +279,4 @@ void __exit ieee80211_crypto_wep_exit(void) > > > > > > void ieee80211_wep_null(void) > > > { > > > -// printk("============>%s()\n", __func__); > > > - return; > > > } > > > > Please just delete the function. > > It is not so easy, the function is exported at file > drivers/staging/rtl8192u/ieee80211/ieee80211.h and used at > drivers/staging/rtl8192u/ieee80211/ieee80211_module.c line 179 with > several other "null" functions, it seems a dirty trick to force module > loading: > /* These function were added to load crypte module autoly */ > ieee80211_tkip_null(); > ieee80211_wep_null(); > ieee80211_ccmp_null(); > > I guess all this stuff should be rewritten to force the autoload > properly but I don't have the knowledge to fix all this. > Sorry Greg :-( Ugh, that's a mess. Ok, I'll take this patch again, please resend it. thanks, greg k-h >