From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <shemming@brocade.com>
Subject: Re: [PATCH v10 03/13] eal/linux: add API to set rx
 interrupt event monitor
Date: Tue, 2 Jun 2015 09:23:00 -0700
Message-ID: <20150602092300.7a615e7e@urahara>
References: <1432889125-20255-1-git-send-email-cunming.liang@intel.com>
 <1433228006-24661-1-git-send-email-cunming.liang@intel.com>
 <1433228006-24661-4-git-send-email-cunming.liang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, liang-min.wang@intel.com
To: Cunming Liang <cunming.liang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx0a-000f0801.pphosted.com (mx0a-000f0801.pphosted.com
 [67.231.144.122]) by dpdk.org (Postfix) with ESMTP id 9CB07BE7C
 for <dev@dpdk.org>; Tue,  2 Jun 2015 18:24:10 +0200 (CEST)
In-Reply-To: <1433228006-24661-4-git-send-email-cunming.liang@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue,  2 Jun 2015 14:53:16 +0800
Cunming Liang <cunming.liang@intel.com> wrote:

> +		bytes_read = read(fd, &buf, bytes_read);
> +		if (bytes_read < 0) {
> +			if (errno == EINTR || errno == EWOULDBLOCK ||
> +			    errno == EAGAIN)
> +				continue;
> +			RTE_LOG(ERR, EAL, "Error reading from file "
> +				"descriptor %d: %s\n", fd,

It is better not to split strings across multiple lines because sometimes
developers need to use tools like grep to find which file has the error
message.

Instead:
			RTE_LOG(ERR, EAL,
				"Error reading from fd %d: %s\n",
				fd, strerror(errno));