From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v2 1/2] ARM: Add cpu_resume_arm() for firmwares that resume in ARM state Date: Tue, 2 Jun 2015 17:11:20 -0700 Message-ID: <20150603001120.GA4534@codeaurora.org> References: <1433272378-8470-1-git-send-email-sboyd@codeaurora.org> <1433272378-8470-2-git-send-email-sboyd@codeaurora.org> <20150602234048.GA7557@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:56148 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751556AbbFCALW (ORCPT ); Tue, 2 Jun 2015 20:11:22 -0400 Content-Disposition: inline In-Reply-To: <20150602234048.GA7557@n2100.arm.linux.org.uk> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Russell King - ARM Linux Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kevin Hilman , Andy Gross , Kumar Gala , Ard Biesheuvel , Lina Iyer On 06/03, Russell King - ARM Linux wrote: > On Tue, Jun 02, 2015 at 12:12:57PM -0700, Stephen Boyd wrote: > > Some platforms always enter the kernel in the ARM state even if > > the kernel is compiled for THUMB2. Add a small wrapper on top of > > cpu_resume() that switches into THUMB2 state. > > > > This fixes a problem reported by Kevin Hilman on next-20150601 > > where the ifc6410 fails to boot a THUMB2 kernel because the > > platform's firmware always enters the kernel in ARM mode from > > deep idle states. > > I think this bit of the commit message isn't quite correct: this will > only resolve the boot problem with a T2 kernel when the failing platform > is converted to use the cpu_resume_arm() entry point. > > Apart from that, the patch looks good to me, thanks. Sure, it could say "This provides the functionality to fix a problem reported by..." -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: sboyd@codeaurora.org (Stephen Boyd) Date: Tue, 2 Jun 2015 17:11:20 -0700 Subject: [PATCH v2 1/2] ARM: Add cpu_resume_arm() for firmwares that resume in ARM state In-Reply-To: <20150602234048.GA7557@n2100.arm.linux.org.uk> References: <1433272378-8470-1-git-send-email-sboyd@codeaurora.org> <1433272378-8470-2-git-send-email-sboyd@codeaurora.org> <20150602234048.GA7557@n2100.arm.linux.org.uk> Message-ID: <20150603001120.GA4534@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/03, Russell King - ARM Linux wrote: > On Tue, Jun 02, 2015 at 12:12:57PM -0700, Stephen Boyd wrote: > > Some platforms always enter the kernel in the ARM state even if > > the kernel is compiled for THUMB2. Add a small wrapper on top of > > cpu_resume() that switches into THUMB2 state. > > > > This fixes a problem reported by Kevin Hilman on next-20150601 > > where the ifc6410 fails to boot a THUMB2 kernel because the > > platform's firmware always enters the kernel in ARM mode from > > deep idle states. > > I think this bit of the commit message isn't quite correct: this will > only resolve the boot problem with a T2 kernel when the failing platform > is converted to use the cpu_resume_arm() entry point. > > Apart from that, the patch looks good to me, thanks. Sure, it could say "This provides the functionality to fix a problem reported by..." -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project