From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754555AbbFELZH (ORCPT ); Fri, 5 Jun 2015 07:25:07 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:36061 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752137AbbFELYt (ORCPT ); Fri, 5 Jun 2015 07:24:49 -0400 Date: Fri, 5 Jun 2015 13:24:43 +0200 From: Ingo Molnar To: Peter Zijlstra Cc: umgwanakikbuti@gmail.com, mingo@elte.hu, ktkhai@parallels.com, rostedt@goodmis.org, tglx@linutronix.de, juri.lelli@gmail.com, pang.xunlei@linaro.org, oleg@redhat.com, wanpeng.li@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/14] sched,lockdep: Employ lock pinning Message-ID: <20150605112443.GA5063@gmail.com> References: <20150605084836.364306429@infradead.org> <20150605085206.235165696@infradead.org> <20150605095738.GB7893@gmail.com> <1433502202.1495.10.camel@twins> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433502202.1495.10.camel@twins> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Peter Zijlstra wrote: > On Fri, 2015-06-05 at 11:57 +0200, Ingo Molnar wrote: > > * Peter Zijlstra wrote: > > > > > Employ the new lockdep lock pinning annotation to ensure no > > > 'accidental' lock-breaks happen with rq->lock. > > > > btw., could we perhaps reorder this series a bit and first see that it > > properly detects the original locking bug, and then only fix the bug? > > > > To make sure the pinning infrastructure works and all that. > > It works; I've had plenty explosions while trying to get some of the less > obvious code paths sorted. I've managed to hit every single WARN I added ;-) > > Also, for bisection it might be annoying to hit known bad points, which is why > its ordered this way. ok! :-) Thanks, Ingo