All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] am33xx: Re-enable SW levelling for DDR2
Date: Fri, 5 Jun 2015 08:46:09 -0400	[thread overview]
Message-ID: <20150605124609.GZ1728@bill-the-cat> (raw)
In-Reply-To: <1433499671-21772-1-git-send-email-lokeshvutla@ti.com>

On Fri, Jun 05, 2015 at 03:51:11PM +0530, Lokesh Vutla wrote:

> From: Tom Rini <trini@ti.com>
> 
> The recent changes for hw leveling on am33xx were not intended for
> DDR2 boards, only DDR3. Update emif_sdram_type to take a sdram_config
> value to check against. This lets us pass in the value we would use to
> configure, when we have not yet configured the board yet.  In other cases
> update the call to be as functional as before and check an already
> programmed value in.
> 
> Tested-by: Yan Liu <yan-liu@ti.com>
> Signed-off-by: Tom Rini <trini@ti.com>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>

OK, I had to re-read this a few times and re-think.  The changes are
fine but the description is a little too vague.  The case that is broken
today is am43xx (which we handle under the am33xx code) and DDR2.
AM335x is still fine befoer and after.  If there's no other comments
I'll re-word things a bit more.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150605/031c700f/attachment.sig>

  reply	other threads:[~2015-06-05 12:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05 10:21 [U-Boot] [PATCH] am33xx: Re-enable SW levelling for DDR2 Lokesh Vutla
2015-06-05 12:46 ` Tom Rini [this message]
2015-06-13  2:10 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150605124609.GZ1728@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.