From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753502AbbFHU1M (ORCPT ); Mon, 8 Jun 2015 16:27:12 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39148 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751459AbbFHU1D (ORCPT ); Mon, 8 Jun 2015 16:27:03 -0400 Date: Mon, 8 Jun 2015 22:26:58 +0200 From: Borislav Petkov To: "Luck, Tony" Cc: "Chen, Gong" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 4/4 Rebase] x86, MCE: Avoid potential deadlock in MCE context Message-ID: <20150608202658.GF5877@pd.tnic> References: <1432150538-3120-1-git-send-email-gong.chen@linux.intel.com> <1432150538-3120-5-git-send-email-gong.chen@linux.intel.com> <20150520092800.GB3645@pd.tnic> <20150522211247.GB4930@gchen.bj.intel.com> <20150522090941.GD3606@pd.tnic> <20150608134127.GE5877@pd.tnic> <3908561D78D1C84285E8C5FCA982C28F32A8E51A@ORSMSX114.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F32A8E51A@ORSMSX114.amr.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 08, 2015 at 08:03:08PM +0000, Luck, Tony wrote: > @@ -156,7 +156,8 @@ void mce_log(struct mce *mce) > /* Emit the trace record: */ > trace_mce_record(mce); > > - atomic_notifier_call_chain(&x86_mce_decoder_chain, 0, mce); > + mce_genpool_add(mce); > + irq_work_queue(&mce_irq_work); > > Is it safe to call irq_work_queue() from MCE context? Yeah, we're using it in contexts like: do_nmi |-> default_do_nmi |-> nmi_handle |->irq_work_queue for example. I think that is good enough for #MC. :) > If that is OK, then I don't have any concerns. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --