From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 9 Jun 2015 08:33:12 +0200 From: "hch@lst.de" Subject: Re: [PATCH v5 02/21] libnvdimm, nfit: initial libnvdimm infrastructure and NFIT support Message-ID: <20150609063312.GA9804@lst.de> References: <20150602001134.4506.45867.stgit@dwillia2-desk3.amr.corp.intel.com> <20150602001419.4506.41953.stgit@dwillia2-desk3.amr.corp.intel.com> <20150603145704.GA22311@lst.de> <1433359473.21035.27.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433359473.21035.27.camel@intel.com> Sender: linux-kernel-owner@vger.kernel.org To: "Williams, Dan J" Cc: "hch@lst.de" , "linux-kernel@vger.kernel.org" , "mingo@kernel.org" , "neilb@suse.de" , "jmoyer@redhat.com" , "linux-api@vger.kernel.org" , "axboe@kernel.dk" , "akpm@linux-foundation.org" , "sfr@canb.auug.org.au" , "linux-nvdimm@lists.01.org" , "gregkh@linuxfoundation.org" , "rafael@kernel.org" , "linux-acpi@vger.kernel.org" List-ID: On Wed, Jun 03, 2015 at 07:24:34PM +0000, Williams, Dan J wrote: > > > +static inline struct acpi_nfit_memory_map *__to_nfit_memdev(struct nfit_mem *nfit_mem) > > > > This line is over 80 characters. > > I generally don't see the point of fixing up occasional small incursions > over 80 characters if it makes the code more amenable to grep. Just use shorter type names or add a line break before the symbol names. Too long lines are highly annoying. From mboxrd@z Thu Jan 1 00:00:00 1970 From: "hch-jcswGhMUV9g@public.gmane.org" Subject: Re: [PATCH v5 02/21] libnvdimm, nfit: initial libnvdimm infrastructure and NFIT support Date: Tue, 9 Jun 2015 08:33:12 +0200 Message-ID: <20150609063312.GA9804@lst.de> References: <20150602001134.4506.45867.stgit@dwillia2-desk3.amr.corp.intel.com> <20150602001419.4506.41953.stgit@dwillia2-desk3.amr.corp.intel.com> <20150603145704.GA22311@lst.de> <1433359473.21035.27.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1433359473.21035.27.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Williams, Dan J" Cc: "hch-jcswGhMUV9g@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "neilb-l3A5Bk7waGM@public.gmane.org" , "jmoyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org" , "akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org" , "sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org" , "linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org" , "gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org" , "rafael-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-acpi@vger.kernel.org On Wed, Jun 03, 2015 at 07:24:34PM +0000, Williams, Dan J wrote: > > > +static inline struct acpi_nfit_memory_map *__to_nfit_memdev(struct nfit_mem *nfit_mem) > > > > This line is over 80 characters. > > I generally don't see the point of fixing up occasional small incursions > over 80 characters if it makes the code more amenable to grep. Just use shorter type names or add a line break before the symbol names. Too long lines are highly annoying. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932139AbbFIGdZ (ORCPT ); Tue, 9 Jun 2015 02:33:25 -0400 Received: from verein.lst.de ([213.95.11.211]:45955 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751355AbbFIGdO (ORCPT ); Tue, 9 Jun 2015 02:33:14 -0400 Date: Tue, 9 Jun 2015 08:33:12 +0200 From: "hch@lst.de" To: "Williams, Dan J" Cc: "hch@lst.de" , "linux-kernel@vger.kernel.org" , "mingo@kernel.org" , "neilb@suse.de" , "jmoyer@redhat.com" , "linux-api@vger.kernel.org" , "axboe@kernel.dk" , "akpm@linux-foundation.org" , "sfr@canb.auug.org.au" , "linux-nvdimm@lists.01.org" , "gregkh@linuxfoundation.org" , "rafael@kernel.org" , "linux-acpi@vger.kernel.org" Subject: Re: [PATCH v5 02/21] libnvdimm, nfit: initial libnvdimm infrastructure and NFIT support Message-ID: <20150609063312.GA9804@lst.de> References: <20150602001134.4506.45867.stgit@dwillia2-desk3.amr.corp.intel.com> <20150602001419.4506.41953.stgit@dwillia2-desk3.amr.corp.intel.com> <20150603145704.GA22311@lst.de> <1433359473.21035.27.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433359473.21035.27.camel@intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 03, 2015 at 07:24:34PM +0000, Williams, Dan J wrote: > > > +static inline struct acpi_nfit_memory_map *__to_nfit_memdev(struct nfit_mem *nfit_mem) > > > > This line is over 80 characters. > > I generally don't see the point of fixing up occasional small incursions > over 80 characters if it makes the code more amenable to grep. Just use shorter type names or add a line break before the symbol names. Too long lines are highly annoying.