From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932661AbbFIKyc (ORCPT ); Tue, 9 Jun 2015 06:54:32 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:35280 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751025AbbFIKyY (ORCPT ); Tue, 9 Jun 2015 06:54:24 -0400 Date: Tue, 9 Jun 2015 12:54:21 +0200 From: Pavel Machek To: Dmitry Torokhov Cc: Samuel Thibault , Pali =?iso-8859-1?Q?Roh=E1r?= , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, rpurdie@rpsys.net, Greg Kroah-Hartman Subject: Re: [PATCH 0/3] Switch input leds over to standard LED class devices Message-ID: <20150609105421.GA15814@amd> References: <1433799790-31873-1-git-send-email-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433799790-31873-1-git-send-email-dmitry.torokhov@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > I finally was able to spend some time looking over Samuel's patch set > switching input LEDs from custom implementation over to standard LED class > devices and I think this is the shape I am reasonably happy with. The > changes: Thanks! > Please take a look and see if you see any holes. Tested on thinkpad t40p. Started X, but then I went to text console for testing. 1) input4::caps-lock -- default trigger was not set, so caps lock did not control the LED. That's bug, right? I did echo kbd-capslock > trigger, but still no luck. (That might be bug in Debian, IIRC?) echo heartbeat > trigger produces expected results. Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html