From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932273AbbFIL0p (ORCPT ); Tue, 9 Jun 2015 07:26:45 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:35862 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753351AbbFIL0h (ORCPT ); Tue, 9 Jun 2015 07:26:37 -0400 Date: Tue, 9 Jun 2015 13:26:34 +0200 From: Pavel Machek To: Dmitry Torokhov Cc: Samuel Thibault , Pali =?iso-8859-1?Q?Roh=E1r?= , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, rpurdie@rpsys.net, Greg Kroah-Hartman Subject: Re: [PATCH 0/3] Switch input leds over to standard LED class devices Message-ID: <20150609112634.GA22539@amd> References: <1433799790-31873-1-git-send-email-dmitry.torokhov@gmail.com> <20150609105421.GA15814@amd> <20150609111242.GA21235@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150609111242.GA21235@amd> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 2015-06-09 13:12:42, Pavel Machek wrote: > On Tue 2015-06-09 12:54:21, Pavel Machek wrote: > > Hi! > > > > > I finally was able to spend some time looking over Samuel's patch set > > > switching input LEDs from custom implementation over to standard LED class > > > devices and I think this is the shape I am reasonably happy with. The > > > changes: > > > > Thanks! > > > > > Please take a look and see if you see any holes. > > > > Tested on thinkpad t40p. Started X, but then I went to text console > > for testing. > > > > 1) input4::caps-lock -- default trigger was not set, so caps lock did > > not control the LED. That's bug, right? > > Strange, on next reboot default triggers were set. Even more strange... setting brightness to zero resets the trigger, setting it to one does not. Oh well, that is problem with other LEDs, too. max_brightness should be 1, AFAICT, but that's also mistake other LEDs make. So Tested-by: Pavel Machek but you don't get acked-by, yet :-). Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html