From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932886AbbFJFig (ORCPT ); Wed, 10 Jun 2015 01:38:36 -0400 Received: from helcar.hengli.com.au ([209.40.204.226]:45909 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751475AbbFJFi1 (ORCPT ); Wed, 10 Jun 2015 01:38:27 -0400 Date: Wed, 10 Jun 2015 13:38:04 +0800 From: Herbert Xu To: Dan Williams Cc: axboe@kernel.dk, Vinod Koul , Linus Walleij , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, hch@lst.de, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] scatterlist: cleanup sg_chain() and sg_unmark_end() Message-ID: <20150610053803.GA1693@gondor.apana.org.au> References: <20150609162659.21910.41681.stgit@dwillia2-desk3.amr.corp.intel.com> <20150609162715.21910.77696.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150609162715.21910.77696.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 09, 2015 at 12:27:15PM -0400, Dan Williams wrote: > > +#define scatterwalk_sg_chain(prv, num, sgl) sg_chain(prv, num, sgl) > +#define scatterwalk_sg_next(sgl) sg_next(sgl) Why are you reintroducing the scatterwalk_sg_next macro that we just removed? I also don't understand why this is so urgent that it has to go into mainline at this late date. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt From mboxrd@z Thu Jan 1 00:00:00 1970 From: herbert@gondor.apana.org.au (Herbert Xu) Date: Wed, 10 Jun 2015 13:38:04 +0800 Subject: [PATCH 2/2] scatterlist: cleanup sg_chain() and sg_unmark_end() In-Reply-To: <20150609162715.21910.77696.stgit@dwillia2-desk3.amr.corp.intel.com> References: <20150609162659.21910.41681.stgit@dwillia2-desk3.amr.corp.intel.com> <20150609162715.21910.77696.stgit@dwillia2-desk3.amr.corp.intel.com> Message-ID: <20150610053803.GA1693@gondor.apana.org.au> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jun 09, 2015 at 12:27:15PM -0400, Dan Williams wrote: > > +#define scatterwalk_sg_chain(prv, num, sgl) sg_chain(prv, num, sgl) > +#define scatterwalk_sg_next(sgl) sg_next(sgl) Why are you reintroducing the scatterwalk_sg_next macro that we just removed? I also don't understand why this is so urgent that it has to go into mainline at this late date. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt