From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933683AbbFJR14 (ORCPT ); Wed, 10 Jun 2015 13:27:56 -0400 Received: from mail.kernel.org ([198.145.29.136]:39341 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932164AbbFJR1s (ORCPT ); Wed, 10 Jun 2015 13:27:48 -0400 Date: Wed, 10 Jun 2015 14:27:43 -0300 From: Arnaldo Carvalho de Melo To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Ingo Molnar Subject: Re: [PATCH] perf, record: Ammend option summaries Message-ID: <20150610172743.GN3136@kernel.org> References: <20150610144850.GP19282@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150610144850.GP19282@twins.programming.kicks-ass.net> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Jun 10, 2015 at 04:48:50PM +0200, Peter Zijlstra escreveu: > > Because there's too many options and I cannot read, I frequently get > confused between -c and -P, and try to do things like: > > perf record -P 50000 -- foo > > Which does not work; try and make the option description slightly longer > and hopefully less confusing. Thanks, I'll check and update tools/perf/Documentation/perf-record.txt, i.e. the man page. - Arnaldo > Signed-off-by: Peter Zijlstra (Intel) > --- > tools/perf/builtin-record.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c > index d3731cc..4d6cdeb 100644 > --- a/tools/perf/builtin-record.c > +++ b/tools/perf/builtin-record.c > @@ -1027,10 +1027,9 @@ struct option __record_options[] = { > OPT_BOOLEAN('q', "quiet", &quiet, "don't print any message"), > OPT_BOOLEAN('s', "stat", &record.opts.inherit_stat, > "per thread counts"), > - OPT_BOOLEAN('d', "data", &record.opts.sample_address, > - "Sample addresses"), > - OPT_BOOLEAN('T', "timestamp", &record.opts.sample_time, "Sample timestamps"), > - OPT_BOOLEAN('P', "period", &record.opts.period, "Sample period"), > + OPT_BOOLEAN('d', "data", &record.opts.sample_address, "Record the sample addresses"), > + OPT_BOOLEAN('T', "timestamp", &record.opts.sample_time, "Record the sample timestamps"), > + OPT_BOOLEAN('P', "period", &record.opts.period, "Record the sample period"), > OPT_BOOLEAN('n', "no-samples", &record.opts.no_samples, > "don't sample"), > OPT_BOOLEAN('N', "no-buildid-cache", &record.no_buildid_cache,