From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754341AbbFJTJq (ORCPT ); Wed, 10 Jun 2015 15:09:46 -0400 Received: from mail.kernel.org ([198.145.29.136]:45494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753428AbbFJTJk (ORCPT ); Wed, 10 Jun 2015 15:09:40 -0400 Date: Wed, 10 Jun 2015 16:09:32 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: lkml , Adrian Hunter , Andi Kleen , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Stephane Eranian Subject: Re: [PATCH 06/25] perf tools: Propagate thread maps through the evlist Message-ID: <20150610190932.GG3332@kernel.org> References: <1433959858-31858-1-git-send-email-jolsa@kernel.org> <1433959858-31858-7-git-send-email-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433959858-31858-7-git-send-email-jolsa@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Jun 10, 2015 at 08:10:39PM +0200, Jiri Olsa escreveu: > Propagate evlist's thread_map object through all the > evsel objects. > > It'll be handy to access evsel's threads directly > in following patches. Handy in what way? I.e. I should know one example without having to look at future patches ;-) - Arnaldo > Link: http://lkml.kernel.org/n/tip-6vc92bytyy2d6c5entm5s698@git.kernel.org > Signed-off-by: Jiri Olsa > --- > tools/perf/util/evlist.c | 4 +++- > tools/perf/util/evsel.c | 1 + > tools/perf/util/evsel.h | 1 + > 3 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c > index 7cb579ca5629..f438881040f2 100644 > --- a/tools/perf/util/evlist.c > +++ b/tools/perf/util/evlist.c > @@ -1100,7 +1100,9 @@ static int propagate_maps(struct perf_evlist *evlist, struct target *target) > if (!evsel->cpus || target->cpu_list) > evsel->cpus = cpu_map__get(evlist->cpus); > > - if (!evsel->cpus) > + evsel->threads = thread_map__get(evlist->threads); > + > + if (!evsel->cpus || !evsel->threads) > return -ENOMEM; > } > > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index 3bd5769dd7b9..bd1c3b71e455 100644 > --- a/tools/perf/util/evsel.c > +++ b/tools/perf/util/evsel.c > @@ -903,6 +903,7 @@ void perf_evsel__exit(struct perf_evsel *evsel) > perf_evsel__free_id(evsel); > close_cgroup(evsel->cgrp); > cpu_map__put(evsel->cpus); > + thread_map__put(evsel->threads); > zfree(&evsel->group_name); > zfree(&evsel->name); > perf_evsel__object.fini(evsel); > diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h > index 21ec08247d47..d18572223b08 100644 > --- a/tools/perf/util/evsel.h > +++ b/tools/perf/util/evsel.h > @@ -82,6 +82,7 @@ struct perf_evsel { > struct cgroup_sel *cgrp; > void *handler; > struct cpu_map *cpus; > + struct thread_map *threads; > unsigned int sample_size; > int id_pos; > int is_pos; > -- > 1.9.3