From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933781AbbFJUHi (ORCPT ); Wed, 10 Jun 2015 16:07:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53477 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933564AbbFJUHb (ORCPT ); Wed, 10 Jun 2015 16:07:31 -0400 Date: Wed, 10 Jun 2015 22:07:21 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , lkml , Adrian Hunter , Andi Kleen , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Stephane Eranian Subject: Re: [PATCH 03/25] perf tools: Add reference counting for cpu_map object Message-ID: <20150610200721.GA6803@krava.redhat.com> References: <1433959858-31858-1-git-send-email-jolsa@kernel.org> <1433959858-31858-4-git-send-email-jolsa@kernel.org> <20150610190746.GE3332@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150610190746.GE3332@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 10, 2015 at 04:07:46PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Jun 10, 2015 at 08:10:36PM +0200, Jiri Olsa escreveu: > > Adding refference counting for cpu_map object, so > > it could be easily shared among other objects. > > > > Using cpu_map__put instead cpu_map__delete and making > > cpu_map__delete static. > > Please use atomic.h, as was done recently for the 'map', 'dso' and > 'thread' structs, but other than that, its fine. ook, jirka