From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2xoV-0004mQ-AQ for qemu-devel@nongnu.org; Thu, 11 Jun 2015 04:26:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z2xoU-0004du-4K for qemu-devel@nongnu.org; Thu, 11 Jun 2015 04:26:15 -0400 Date: Thu, 11 Jun 2015 10:26:05 +0200 From: Kevin Wolf Message-ID: <20150611082605.GA4818@noname.redhat.com> References: <1433957094-8303-1-git-send-email-jsnow@redhat.com> <5578A371.2060602@redhat.com> <5578A428.7080001@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BOKacYhQ+x31HxR3" Content-Disposition: inline In-Reply-To: <5578A428.7080001@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block: Change bitmap truncate conditional to assertion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: vsementsov@virtuozzo.com, qemu-devel@nongnu.org, qemu-block@nongnu.org --BOKacYhQ+x31HxR3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 10.06.2015 um 22:55 hat John Snow geschrieben: > On 06/10/2015 04:52 PM, Eric Blake wrote: > > On 06/10/2015 11:24 AM, John Snow wrote: > >> Requires: 1433796555-5608-1-git-send-email-jsnow@redhat.com=20 > >> [PATCH] block: record new size in bdrv_dirty_bitmap_truncate > >>=20 > >=20 > > Shouldn't this be after the '---' separator? > >=20 >=20 > Sorry, not used to sending single patches without a cover letter. >=20 > Kevin: If it's not inconvenient for you to do, please delete these > lines on commit. No problem. > >> This is an artifact of an older version that had both all-bitmap > >> and single-bitmap truncate functions, and some info got lost in > >> the shuffle. > >>=20 > >> Bitmaps can only be frozen during a backup operation, and a > >> backup operation should prevent a resize operation, so just > >> assert that this cannot happen. > >>=20 > >> Suggested-by: Kevin Wolf Signed-off-by: John > >> Snow --- block.c | 4 +--- 1 file changed, 1 > >> insertion(+), 3 deletions(-) > >=20 > > Reviewed-by: Eric Blake Thanks, applied to the block branch. Kevin --BOKacYhQ+x31HxR3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJVeUYdAAoJEH8JsnLIjy/WuL4P/RzGCh0H+bh3AfXdg3XD4KHL lTarSwUsE98nCwFOaT6HCmV24T6Q2q/1EXnVK7wotEaVhFUlxBJiplhYwU28rF4d qMSTZzz9Uw5CiVhaRSM2BhZnxJXfJ88OB09uWd7sOAaghjSp0dj4IoxrJW+Nag5I y1tF+FHir/wjjYnhS7RbuCRSKjXizhFAgNPfdLID5hYeHtKNS+++r++Bo6c9e2ql 9SYKONBGyD3/A3m4Eom2noxj0OxqhpXjpUPYRYepAIHFm7useUnkeGU0D34Gd74X vIJR4+B7ExHsBw+wQuI4gPwyxbR8/rcc89hYPbJ32sXzs4Y6+F27m+HrA2fHOp/c pIuKgdnoS09emJ24dUE9oPxz6mo9VZNqgU3LqEhV8ShDoW57rBhOmP9/6/Gwh96h WU5Thb7gO/khYCY35c5zsU2rOgwPG0O4thD62mrhSSJr0BvuzjaXo7EaFl0Gilit a/NPv8pQMedsigDmPa5+wwE9KL3j/GbMDYsTsOAswn7l9CBuCacD3/nRRyCCNM4H Hi8oRkIw2atTQbUnYBawa1TmTFawvZFlqdhrl9i7Hon+1hqSxCSJKUjtMf4zC0Uu SDTSJJkmhk0nejAPAk7PpxRRIlCTkuCQZEfZ1WPL2SafQSvV94as1djdo02dWdFB CRwRRW9RQjKedY5j2t2I =xojU -----END PGP SIGNATURE----- --BOKacYhQ+x31HxR3--