All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Jonathan Richardson <jonathar@broadcom.com>
Cc: Tim Kryger <tim.kryger@gmail.com>,
	Dmitry Torokhov <dtor@google.com>,
	Anatol Pomazau <anatol@google.com>,
	Arun Ramamurthy <arun.ramamurthy@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
	linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
	Arun Ramamurthy <arunrama@broadcom.com>
Subject: Re: [PATCH v8 2/5] drivers: pwm: bcm-kona: Dont set polarity in probe
Date: Fri, 12 Jun 2015 11:46:21 +0200	[thread overview]
Message-ID: <20150612094605.GD19400@ulmo.nvidia.com> (raw)
In-Reply-To: <1432670900-27687-3-git-send-email-jonathar@broadcom.com>

[-- Attachment #1: Type: text/plain, Size: 821 bytes --]

On Tue, May 26, 2015 at 01:08:17PM -0700, Jonathan Richardson wrote:
> From: Arun Ramamurthy <arunrama@broadcom.com>
> 
> Omit setting the polarity to normal during probe and instead use the
> new pwmchip_add_inversed function to register a PWM chip with default
> polarity of inversed for all channels as this is the actual hardware
> default.
> 
> Signed-off-by: Arun Ramamurthy <arunrama@broadcom.com>
> Reviewed-by: Ray Jui <rjui@broadcom.com>
> Signed-off-by: Scott Branden <sbranden@broadcom.com>
> Signed-off-by: Tim Kryger <tim.kryger@gmail.com>
> Signed-off-by: Jonathan Richardson <jonathar@broadcom.com>
> ---
>  drivers/pwm/pwm-bcm-kona.c |    9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)

Applied, after adapting to the pwmchip_add_with_polarity() API, thanks.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-06-12  9:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-26 20:08 [PATCH v8 0/5] Fix bugs in kona pwm driver and pwm core Jonathan Richardson
2015-05-26 20:08 ` Jonathan Richardson
2015-05-26 20:08 ` [PATCH v8 1/5] drivers: pwm: core: Add pwmchip_add_inversed Jonathan Richardson
2015-05-26 20:08   ` Jonathan Richardson
2015-06-12  9:45   ` Thierry Reding
2015-06-15  0:51     ` Tim Kryger
2015-05-26 20:08 ` [PATCH v8 2/5] drivers: pwm: bcm-kona: Dont set polarity in probe Jonathan Richardson
2015-05-26 20:08   ` Jonathan Richardson
2015-06-12  9:46   ` Thierry Reding [this message]
2015-05-26 20:08 ` [PATCH v8 3/5] pwm: kona: Fix incorrect config, disable, and polarity procedures Jonathan Richardson
2015-05-26 20:08   ` Jonathan Richardson
2015-05-30 16:41   ` Tim Kryger
2015-06-12 21:28     ` Jonathan Richardson
2015-05-26 20:08 ` [PATCH v8 4/5] pwm: kona: Add debug info to config function Jonathan Richardson
2015-05-26 20:08   ` Jonathan Richardson
2015-05-30 16:42   ` Tim Kryger
2015-06-12 21:29     ` Jonathan Richardson
2015-05-26 20:08 ` [PATCH v8 5/5] pwm: core: Set enable state properly on failed call to enable Jonathan Richardson
2015-05-26 20:08   ` Jonathan Richardson
2015-06-12  9:49   ` Thierry Reding
2015-06-12 19:22     ` Jonathan Richardson
2015-06-12 19:22       ` Jonathan Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150612094605.GD19400@ulmo.nvidia.com \
    --to=thierry.reding@gmail.com \
    --cc=anatol@google.com \
    --cc=arun.ramamurthy@broadcom.com \
    --cc=arunrama@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=dtor@google.com \
    --cc=jonathar@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=tim.kryger@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.