From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752567AbbFMVXf (ORCPT ); Sat, 13 Jun 2015 17:23:35 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36283 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751966AbbFMVX3 (ORCPT ); Sat, 13 Jun 2015 17:23:29 -0400 Date: Sat, 13 Jun 2015 14:23:28 -0700 From: Greg KH To: Tomas Winkler Cc: arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [char-misc-next 06/17] mei: bus: add kdoc for device attribute functions Message-ID: <20150613212328.GE13609@kroah.com> References: <1434222709-10966-1-git-send-email-tomas.winkler@intel.com> <1434222709-10966-7-git-send-email-tomas.winkler@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434222709-10966-7-git-send-email-tomas.winkler@intel.com> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 13, 2015 at 10:11:38PM +0300, Tomas Winkler wrote: > 1. Rename uevent handler to mei_cl_device_uevent > 2. Add kdoc for uevent and mod alias functions 2 things in one patch? No, please make these separate patches. And why add kdoc to static functions? That makes no sense. greg k-h