[PATCH 1/1] wm831x_power: Fix off-by-one at free_irq()

[PATCH 1/1] wm831x_power: Fix off-by-one at free_irq()

[Takeshi Yoshimura]

An error handling in wm831x_power_probe() mistakenly frees a failed-to-
request irq as well as other irqs. I added missing decrement of the loop
counter.

Signed-off-by: Takeshi Yoshimura <yos@sslab.ics.keio.ac.jp>
---
 drivers/power/wm831x_power.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/power/wm831x_power.c b/drivers/power/wm831x_power.c
index 0161bda..db11ae6 100644
--- a/drivers/power/wm831x_power.c
+++ b/drivers/power/wm831x_power.c
@@ -609,6 +609,7 @@ static int wm831x_power_probe(struct platform_device *pdev)
 	return ret;
 
 err_bat_irq:
+	--i;
 	for (; i >= 0; i--) {
 		irq = platform_get_irq_byname(pdev, wm831x_bat_irqs[i]);
 		free_irq(irq, power);
-- 
1.9.1

Re: [PATCH 1/1] wm831x_power: Fix off-by-one at free_irq()

[Charles Keepax]

On Sun, Jun 14, 2015 at 08:55:18PM +0900, Takeshi Yoshimura wrote:
> An error handling in wm831x_power_probe() mistakenly frees a failed-to-
> request irq as well as other irqs. I added missing decrement of the loop
> counter.
> 
> Signed-off-by: Takeshi Yoshimura <yos@sslab.ics.keio.ac.jp>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles

Re: [PATCH 1/1] wm831x_power: Fix off-by-one at free_irq()

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

Hi,

On Sun, Jun 14, 2015 at 08:55:18PM +0900, Takeshi Yoshimura wrote:
> An error handling in wm831x_power_probe() mistakenly frees a failed-to-
> request irq as well as other irqs. I added missing decrement of the loop
> counter.

Thanks, applied.

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]