From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755455AbbFOOQJ (ORCPT ); Mon, 15 Jun 2015 10:16:09 -0400 Received: from mail-bl2on0130.outbound.protection.outlook.com ([65.55.169.130]:39840 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753842AbbFOOP6 (ORCPT ); Mon, 15 Jun 2015 10:15:58 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; amacapital.net; dkim=none (message not signed) header.d=none; X-WSS-ID: 0NPZOYI-07-AAB-02 X-M-MSG: Date: Mon, 15 Jun 2015 22:14:59 +0800 From: Huang Rui To: Peter Zijlstra CC: Borislav Petkov , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , "Rafael J. Wysocki" , Len Brown , John Stultz , =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , , , Fengguang Wu , Aaron Lu , Suravee Suthikulanit , Tony Li , Ken Xue Subject: Re: [PATCH v5 2/2] x86, mwaitt: introduce mwaix delay with a configurable timer Message-ID: <20150615141458.GC28310@hr-slim.amd.com> References: <1434365284-1495-1-git-send-email-ray.huang@amd.com> <1434365284-1495-3-git-send-email-ray.huang@amd.com> <20150615105718.GW3644@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150615105718.GW3644@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD028;1:665CQsTK3m4E4CoEtuoX8x0JX6r2TxW9w0SSCZ9tsn+y7XVvM9Ddtvsgxv/NdUX4n6k1lDt6B4cpZRRHIBpS6ccdpMoVFjL8/cYwXoMPRFXna3HzrRYDyFOtE12/opE3jkJrXllfzCLFKDQ2TIlZTxuZBU7oE+fjPLW4HnXE0SWD17Nky/Kp4JlRkvp00W5LfId6TM5YypYAstJifo0WcYFfkY1zaxYZ1Jd7CInj1+/QWpkSzHAcdE2o5En44b2YguOtuoDlGvnV4fUdGuA821wWFz1MnS1GNpfPdt/KTw6MHZR3k1QedmdftTEqqysz70HeHThtL/Rl8hz+xCwgSFekUO21t7VVG3aUiquf+/U= X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(428002)(164054003)(199003)(189002)(24454002)(46406003)(33656002)(106466001)(83506001)(50466002)(87936001)(101416001)(76176999)(5003600100002)(54356999)(46102003)(50986999)(110136002)(189998001)(4001350100001)(77096005)(86362001)(92566002)(97756001)(2950100001)(53416004)(23726002)(77156002)(47776003)(62966003)(105586002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR02MB1115;H:atltwp01.amd.com;FPR:;SPF:None;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY1PR02MB1115;2:9E+kHCNDwBpVkczvqwb6C7BNcT6ubnJiZYLnwgrfoGONz/sICLM1S8S4ngLFWd40;2:S7JVGISS/U+tKvwMT+I0GBSnPcgHd6Xclo5wSg+3SaFSY8c8bXbp1zzLTKAbwMzbwD/kZm+M5/V2xohcDJD71yLEjqXY8cYxy7/hj8KQuGWBbbMBx7e0QB2oFfcrxb4Hu/GcKzf8p7by78cDgB40XGrbudyFPxv3i2B6h8Lqj6SoLkWfIJ/F2P99MU/pJDIZJhapx26Q5FT7KZrxXvzCLSu+jAsZTiu7/S1yPlGMX9RGpw5r3WQpfAHiYqCl2RHE;6:+z7h2mR0vzWw5p4NKLDvt8yqxqWv8zrvnLV24GcoNUQUc3cxypeSHxijGj28OwmgJ/vzkU1zHGRvKvqXbMI4zGU/wOqOWp7NEkbdLSH50z7cFhyljcI8Rta7ttJHrKh/LtE8H2+qp2WMMqSiOoFJmyBevnHsiEib3rwFan5r4I+1CIJDp1YMDy2V5y8RRYsKZHKpH7Cjq/pG//1UlnfstkCUGaahTjocerDuuDREvDdk5IUWMwNy75JzmXkODm/QrWpW2dtr8P2txZnBc1DhDO9pmqaTIUDZ8rYG1AnxF42h12OwGr2T0xvWLqBGa/2VL/0aE/sGCLgTGi9KaltrrY4cnc8sQ6httGe+Q+IZJb9oLssqb0EfEoCVsJHm8ay/WmsI3K1c3DoYiX5dC/NdCKICu5ufVv4wszgb/pj4chBDnIPpVF87wvFkc9GVjrxV9FZxtmnZMvyVizb7VTTZBIkfYfnuVeXTEKn//SsnO2YdDsxXEjRGDnev/MrVLZAG X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR02MB1115; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:BY1PR02MB1115;BCL:0;PCL:0;RULEID:;SRVR:BY1PR02MB1115; X-Microsoft-Exchange-Diagnostics: 1;BY1PR02MB1115;3:rZ7QDbiFa0UZK6S5cvF//SxtYNvuW+A2ia5Bwes1YxEPNWuajXo+woyXM7fV6gbVGrIzJQZGOA8flpchuCt2L08fIO258fIBs6laPXGxpqpLXAGYydiwHEehV66D4YlpROGAuH/aDzPDVPILwWsk20KlCxcybbhoxBDYraj6+Kvv6zgc8bX4mrXcvpbX03r3DHipT0CXCflCpR0lqI6eZgrDzt9s0Tti+Udg4ESH3n0rML8VxSkhbVAbMeepT1o8uO+DbgqfnEBzd7vUhtopjA7rlCN1EF3V2lsWOIiykkF6iVYkVl8Ic39uQKYsTKfl X-Forefront-PRVS: 0608DEDB67 X-Microsoft-Exchange-Diagnostics: 1;BY1PR02MB1115;9:TYcLZqbfjOy6ax7iPXXDzSGmcu1gQxupIKXl9eZOvaRwmLvheQZZ/m/MVx6d1p7h9hUR03v5m9l62xo5V/+k8reubhN2lQA+UJwPa6G1qMF2aQyLvpFFfKp87ZYAUUxflbJzSbvFAZXjDPSKWOYx8c8WICkYWN09poHcV8gQ+zglToZVhm4NwIiaqN0fllNNeSrsoQ0HlEs8sBYVgG4fcjMerj5CqmwD/EGGvlVI8Ir2w2/5NkB+pRDdjxMqJ/kOqbdL56ZYawn9Zn2XUyZ4JUhV5nQrBOG96O9sj1xW5+qEq2qJXcCfveqW29EBrgcvQlbsy3+O6F1pCur5rNAiYpCtoRkdM0wGciux/fgT+T+NArrYqCwHqDf68lqx06iOxanLuSA5SPF4CsMZmjHqMXkUt1XRgRPSS1sBhint6rdelqpoRbRLTkRcUeMzwRxStFnwA/GkcK/hqSgFHgjHkenMD+ied51tyCgdsdWfhDqWbvpxJu8ioTqBP5TbquZhIPC7oEY4ZF1xutvvyf7qHCtjNpNyogidUkKuUnSm0l8iJhDpKjwRlPLYAVhuMJdqQyVVtrZUDX1g8Sk6d6YtR2u7hd32xLhUR/ZT0bnLfA9Pr2SxR6TtJPFSY3kziSVudQy+fTaeYHPQephmvgFg17AhhZ6SvSCu15frvfcuCo5iN/VUapkXkVFqtu84qqB/VWy5Y8njMphOJWuCEE4ZnGvco/f94eihLh1f+IQrSSA0hdkY+JliQQClZbj0IfwvTCF2A6m8GiMJlE5iLot0HHuGdVSIcW7YG/9ZKZH58UBhMUJo8H7KfyIunIxHWcgwZtsl0Vjv8uaCCsG8+mnWhg== X-Microsoft-Exchange-Diagnostics: 1;BY1PR02MB1115;3:6142DiUjztSYweEzOYUfZhBHOIa2pkJfJdxcojh73sZVzbLP8LNyBguzQVLa0lfXxsNaaq4Fqimfj33pIQehMWY18d97RtjnVh5GNd0x8syO04eNFP/DAoaRyo92mgyO6cxFa+EB6ErhV7I3DiStSA==;10:iFYKfxLQ93C8tEpfAnUCGeRYlBjJR0vO25exE6T90kXb+urL1wFQaDTmVu53nCovmlCyt1E7Kifn2NHI55jJc9ReKXNg+E8VAK1uy5PdApw=;6:PtBsvzdlyLU+q6rc8CIMK+xOtfbUzCrEnw3hR/PkHv5mAZaViiIaggL1dIFGHjYS X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2015 14:15:55.8365 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR02MB1115 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 15, 2015 at 12:57:18PM +0200, Peter Zijlstra wrote: > On Mon, Jun 15, 2015 at 06:48:04PM +0800, Huang Rui wrote: > > diff --git a/arch/x86/include/asm/mwait.h b/arch/x86/include/asm/mwait.h > > index 1fbc89d..47f3540 100644 > > --- a/arch/x86/include/asm/mwait.h > > +++ b/arch/x86/include/asm/mwait.h > > @@ -14,6 +14,9 @@ > > #define CPUID5_ECX_INTERRUPT_BREAK 0x2 > > > > #define MWAIT_ECX_INTERRUPT_BREAK 0x1 > > +#define MWAITX_ECX_TIMER_ENABLE BIT(1) > > +#define MWAITX_MAX_LOOPS ((u32)-1) > > +#define MWAITX_DISABLE_CSTATES 0xf > > > > static inline void __monitor(const void *eax, unsigned long ecx, > > unsigned long edx) > > Should this hunk not be part of the previous patch? > This definitions are used to implement delay function, so I put it at this patch. :) Thanks, Rui