From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4W3t-0001ag-7F for qemu-devel@nongnu.org; Mon, 15 Jun 2015 11:12:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4W3o-0002yc-W9 for qemu-devel@nongnu.org; Mon, 15 Jun 2015 11:12:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54069) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4W3o-0002yY-Mx for qemu-devel@nongnu.org; Mon, 15 Jun 2015 11:12:28 -0400 Date: Mon, 15 Jun 2015 16:12:26 +0100 From: Stefan Hajnoczi Message-ID: <20150615151226.GH12553@stefanha-thinkpad.redhat.com> References: <1434205258-1932-1-git-send-email-armbru@redhat.com> <1434205258-1932-6-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="RwGu8mu1E+uYXPWP" Content-Disposition: inline In-Reply-To: <1434205258-1932-6-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH 05/11] qerror: Clean up QERR_ macros to expand into a single string List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: mdroth@linux.vnet.ibm.com, kwolf@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com --RwGu8mu1E+uYXPWP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 13, 2015 at 04:20:52PM +0200, Markus Armbruster wrote: > These macros expand into error class enumeration constant, comma, > string. Unclean. Has been that way since commit 13f59ae. >=20 > The error class is always ERROR_CLASS_GENERIC_ERROR since the previous > commit. >=20 > Clean up as follows: >=20 > * Prepend every use of a QERR_ macro by ERROR_CLASS_GENERIC_ERROR, and > delete it from the QERR_ macro. No change after preprocessing. >=20 > * Rewrite error_set(ERROR_CLASS_GENERIC_ERROR, ...) into > error_setg(...). Again, no change after preprocessing. >=20 > Signed-off-by: Markus Armbruster > --- > backends/rng-egd.c | 8 ++--- > backends/rng-random.c | 6 ++-- > backends/rng.c | 2 +- > backends/tpm.c | 2 +- > balloon.c | 2 +- > block.c | 2 +- > block/backup.c | 4 +-- > block/commit.c | 2 +- > block/mirror.c | 8 ++--- > block/qcow.c | 4 +-- > block/qcow2.c | 4 +-- > block/qed.c | 4 +-- > block/quorum.c | 4 +-- > block/snapshot.c | 4 +-- > block/stream.c | 4 +-- > block/vmdk.c | 12 ++++---- > blockdev-nbd.c | 2 +- > blockdev.c | 43 +++++++++++++------------- > blockjob.c | 8 ++--- > cpus.c | 8 ++--- > dump.c | 12 ++++---- > hmp.c | 10 +++--- > hw/core/nmi.c | 2 +- > hw/core/qdev-properties-system.c | 3 +- > hw/core/qdev-properties.c | 12 ++++---- > hw/core/qdev.c | 8 ++--- > hw/intc/openpic.c | 6 ++-- > hw/pci/pci-stub.c | 2 +- > hw/ppc/spapr_pci.c | 8 ++--- > hw/s390x/s390-virtio.c | 2 +- > hw/usb/redirect.c | 6 ++-- > include/qapi/qmp/qerror.h | 60 ++++++++++++++++++----------------= -- > migration/migration.c | 35 ++++++++++----------- > migration/savevm.c | 2 +- > monitor.c | 66 ++++++++++++++++++++--------------= ------ > net/net.c | 12 ++++---- > qapi/opts-visitor.c | 24 +++++++-------- > qapi/qapi-visit-core.c | 28 ++++++++--------- > qapi/qmp-dispatch.c | 12 ++++---- > qapi/qmp-input-visitor.c | 28 ++++++++--------- > qapi/string-input-visitor.c | 24 +++++++-------- > qdev-monitor.c | 12 ++++---- > qemu-img.c | 2 +- > qga/commands-posix.c | 40 ++++++++++++------------ > qga/commands-win32.c | 66 ++++++++++++++++++++--------------= ------ > qga/main.c | 4 +-- > qmp.c | 34 ++++++++++----------- > qom/object.c | 12 ++++---- > stubs/arch-query-cpu-def.c | 2 +- > target-i386/cpu.c | 19 ++++++------ > tpm.c | 8 +++-- > ui/vnc.c | 4 +-- > util/qemu-option.c | 22 ++++++++------ > 53 files changed, 362 insertions(+), 358 deletions(-) Nice simplification. Reviewed-by: Stefan Hajnoczi --RwGu8mu1E+uYXPWP Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEbBAEBAgAGBQJVfutaAAoJEJykq7OBq3PIQvYH9RO43zTNGnCAaH+hun+0d9na 3TlaRELLvqfBWZ1SDOSobqCEaQwccVwioMUjqex2bgjtN+kbRUdrgDr9dwIWqFFt G2YpqDYCGz+HcgVsG8okp4yNTAyWcnUZesb+vQuoUT60BcQGFOw+XMttYzyXCpqH gHl7PKEVZ8gwlVjJ9rn+O2ky6velLEKJLwChXzW+9M5KZr7KlOdihhAfEgnjY+hf JWDmbby1tW6YeEPsnVVZvKKHPPsU/v6wIwaQP0kMduQ9oV+yL26xslMaInWMboBu QfxyCXjgUySpyY+9u3ZV9WPWx8LDe5M03r/hIO40Lh5Nn3ZJmQiU9xDrHlhvvw== =oS6C -----END PGP SIGNATURE----- --RwGu8mu1E+uYXPWP--