From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755982AbbFPGyS (ORCPT ); Tue, 16 Jun 2015 02:54:18 -0400 Received: from isilmar-3.linta.de ([188.40.101.200]:39258 "EHLO linta.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751419AbbFPGyJ (ORCPT ); Tue, 16 Jun 2015 02:54:09 -0400 Date: Tue, 16 Jun 2015 08:19:42 +0200 From: Dominik Brodowski To: Alan Cox Cc: linux-kernel@vger.kernel.org, linux-pcmica@lists.infradead.org Subject: Re: [PATCH 4/5] pcmcia: handle anonymous cards by generating a fake CIS Message-ID: <20150616061942.GA27671@light.dominikbrodowski.net> References: <20141204212746.1351.89165.stgit@localhost.localdomain> <20141204213015.1351.23846.stgit@localhost.localdomain> <20150614195246.GA13314@light.dominikbrodowski.net> <1434370255.25843.8.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434370255.25843.8.camel@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 15, 2015 at 01:10:55PM +0100, Alan Cox wrote: > > Unfortunately, this patch does not work well with all of the callers of > > pccard_validate_cis(). While it helps for ds.c:pcmcia_card_add() and does > > not matter for cistpl.c:pccard_show_cis(), it breaks the callback in > > rsrc_nonstatic.c:readable(): > > I'm not sure it's the right way to do readable() but we seem to be stuck > with that anyway. Indeed - any replacement would need much testing at least. > > The change looks good to me, and I will try and test it soon but it may > take some time due to various other things going on in life. Can you > submit it for 4.2 anyway and give it a bit of time for any screaming > then push to stable ? Have added it to my tree, and will do as you suggest. Thanks, Dominik