From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756602AbbFPP1Q (ORCPT ); Tue, 16 Jun 2015 11:27:16 -0400 Received: from fieldses.org ([173.255.197.46]:43760 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752907AbbFPP1K (ORCPT ); Tue, 16 Jun 2015 11:27:10 -0400 Date: Tue, 16 Jun 2015 11:27:09 -0400 From: "J. Bruce Fields" To: Fabian Frederick Cc: linux-kernel@vger.kernel.org, Julia Lawall , linux-nfs@vger.kernel.org Subject: Re: [PATCH 1/1 linux-next] nfsd: use swap() in sort_pacl_range() Message-ID: <20150616152709.GA2147@fieldses.org> References: <1434128337-10366-1-git-send-email-fabf@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434128337-10366-1-git-send-email-fabf@skynet.be> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applying, thanks.--b. On Fri, Jun 12, 2015 at 06:58:57PM +0200, Fabian Frederick wrote: > Use kernel.h macro definition. > > Thanks to Julia Lawall for Coccinelle scripting support. > > Signed-off-by: Fabian Frederick > --- > fs/nfsd/nfs4acl.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/nfsd/nfs4acl.c b/fs/nfsd/nfs4acl.c > index 7e10e2a..eb5accf 100644 > --- a/fs/nfsd/nfs4acl.c > +++ b/fs/nfsd/nfs4acl.c > @@ -372,7 +372,6 @@ pace_gt(struct posix_acl_entry *pace1, struct posix_acl_entry *pace2) > static void > sort_pacl_range(struct posix_acl *pacl, int start, int end) { > int sorted = 0, i; > - struct posix_acl_entry tmp; > > /* We just do a bubble sort; easy to do in place, and we're not > * expecting acl's to be long enough to justify anything more. */ > @@ -382,9 +381,8 @@ sort_pacl_range(struct posix_acl *pacl, int start, int end) { > if (pace_gt(&pacl->a_entries[i], > &pacl->a_entries[i+1])) { > sorted = 0; > - tmp = pacl->a_entries[i]; > - pacl->a_entries[i] = pacl->a_entries[i+1]; > - pacl->a_entries[i+1] = tmp; > + swap(pacl->a_entries[i], > + pacl->a_entries[i + 1]); > } > } > } > -- > 2.4.2