All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: linux-mtd@lists.infradead.org
Cc: Richard Weinberger <richard@nod.at>, Alexander Shiyan <shc_work@mail.ru>
Subject: Re: [PATCH 1/4] mtd: diskonchip: remove two-phase partitioning / registration
Date: Tue, 16 Jun 2015 18:51:47 -0700	[thread overview]
Message-ID: <20150617015147.GC4917@ld-irv-0074> (raw)
In-Reply-To: <1433200640-17858-1-git-send-email-computersforpeace@gmail.com>

On Mon, Jun 01, 2015 at 04:17:17PM -0700, Brian Norris wrote:
> It is a Bad Idea (TM) to call mtd_device_register() or
> mtd_device_parse_register() twice on the same master MTD. Among other
> things, it makes partition overrides (e.g., cmdlinepart) much more
> difficult.
> 
> Since commit 727dc612c46b ("mtd: part: Create the master device node
> when partitioned"), we now have a config option that accomplishes the
> same purpose as the double-registration done in diskonchip.c -- it
> forces the master MTD to *always* be registered, while partitions may
> optionally show up in addition. Eventually, we might like to make
> CONFIG_MTD_PARTITIONED_MASTER into the default, but this could be
> disruptive to user-space expectations of MTD numbering, so we'll take
> that slowly.
> 
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Alexander Shiyan <shc_work@mail.ru>

Pushed patch 1 and 2, minus the FIXME's.

      parent reply	other threads:[~2015-06-17  1:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-01 23:17 [PATCH 1/4] mtd: diskonchip: remove two-phase partitioning / registration Brian Norris
2015-06-01 23:17 ` [PATCH 2/4] mtd: propagate error codes from add_mtd_device() Brian Norris
2015-06-02  8:02   ` Richard Weinberger
2015-06-03  0:00     ` Brian Norris
2015-06-01 23:17 ` [PATCH 3/4] mtd: fixup corner case error handling in mtd_device_parse_register() Brian Norris
2015-06-02  8:03   ` Richard Weinberger
2015-10-26 21:34     ` Brian Norris
2015-06-01 23:17 ` [PATCH 4/4] mtd: warn when registering the same master many times Brian Norris
2015-06-02  8:03   ` Richard Weinberger
2015-10-26 21:35     ` Brian Norris
2015-06-17  1:51 ` Brian Norris [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150617015147.GC4917@ld-irv-0074 \
    --to=computersforpeace@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.