All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: davem@davemloft.net, willemb@google.com, al.drozdov@gmail.com,
	viro@zeniv.linux.org.uk, eyal.birger@gmail.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	pankaj.m@samsung.com
Subject: Re: [RESUBMIT Patch 1/1] net: replace if()/BUG with BUG_ON
Date: Wed, 17 Jun 2015 08:28:14 +0200	[thread overview]
Message-ID: <20150617062743.GA18998@redhat.com> (raw)
In-Reply-To: <1434515761-14796-1-git-send-email-maninder1.s@samsung.com>

On Wed, Jun 17, 2015 at 10:06:01AM +0530, Maninder Singh wrote:
> Use BUG_ON(condition) instead of if(condition)/BUG() .
> 
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Reviewed-by: Akhilesh Kumar <akhilesh.k@samsung.com>

Why not?

Acked-by: Michael S. Tsirkin <mst@redhat.com>


> ---
>  net/packet/af_packet.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
> index b5989c6..c91d405 100644
> --- a/net/packet/af_packet.c
> +++ b/net/packet/af_packet.c
> @@ -547,8 +547,7 @@ static void prb_setup_retire_blk_timer(struct packet_sock *po, int tx_ring)
>  {
>  	struct tpacket_kbdq_core *pkc;
>  
> -	if (tx_ring)
> -		BUG();
> +	BUG_ON(tx_ring);
>  
>  	pkc = tx_ring ? GET_PBDQC_FROM_RB(&po->tx_ring) :
>  			GET_PBDQC_FROM_RB(&po->rx_ring);
> -- 
> 1.7.1

  reply	other threads:[~2015-06-17  6:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17  4:36 [RESUBMIT Patch 1/1] net: replace if()/BUG with BUG_ON Maninder Singh
2015-06-17  6:28 ` Michael S. Tsirkin [this message]
2015-06-17  7:36 ` Frans Klaver
2015-06-17  8:26   ` Alexander Drozdov
2015-06-17  8:30     ` Frans Klaver
2015-06-21 16:55       ` David Miller
2015-06-21 16:55         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150617062743.GA18998@redhat.com \
    --to=mst@redhat.com \
    --cc=al.drozdov@gmail.com \
    --cc=davem@davemloft.net \
    --cc=eyal.birger@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maninder1.s@samsung.com \
    --cc=netdev@vger.kernel.org \
    --cc=pankaj.m@samsung.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.