From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5IF4-0006Bx-Uf for qemu-devel@nongnu.org; Wed, 17 Jun 2015 14:39:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5IF1-000646-Ie for qemu-devel@nongnu.org; Wed, 17 Jun 2015 14:39:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59786) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5IF1-00063Y-DZ for qemu-devel@nongnu.org; Wed, 17 Jun 2015 14:39:15 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 0E7C4C463A for ; Wed, 17 Jun 2015 18:39:14 +0000 (UTC) Date: Wed, 17 Jun 2015 19:39:10 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20150617183909.GR2122@work-vm> References: <1434505833-11234-1-git-send-email-quintela@redhat.com> <1434505833-11234-2-git-send-email-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434505833-11234-2-git-send-email-quintela@redhat.com> Subject: Re: [Qemu-devel] [PATCH 01/11] runstate: Add runstate store List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: amit.shah@redhat.com, qemu-devel@nongnu.org * Juan Quintela (quintela@redhat.com) wrote: > This allows us to store the current state to send it through migration. > > Signed-off-by: Juan Quintela > --- > include/sysemu/sysemu.h | 1 + > vl.c | 12 ++++++++++++ > 2 files changed, 13 insertions(+) > > diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h > index 0304aa7..d7bec42 100644 > --- a/include/sysemu/sysemu.h > +++ b/include/sysemu/sysemu.h > @@ -28,6 +28,7 @@ bool runstate_check(RunState state); > void runstate_set(RunState new_state); > int runstate_is_running(void); > bool runstate_needs_reset(void); > +bool runstate_store(char *str, size_t size); > typedef struct vm_change_state_entry VMChangeStateEntry; > typedef void VMChangeStateHandler(void *opaque, int running, RunState state); > > diff --git a/vl.c b/vl.c > index 2201e27..c659a00 100644 > --- a/vl.c > +++ b/vl.c > @@ -630,6 +630,18 @@ bool runstate_check(RunState state) > return current_run_state == state; > } > > +bool runstate_store(char *str, size_t size) > +{ > + const char *state = RunState_lookup[current_run_state]; > + size_t len = strlen(state) + 1; > + > + if (len > size) { > + return false; > + } > + memcpy(str, state, len); > + return true; > +} > + It seems a lot of work for a status string; but OK. Reviewed-by: Dr. David Alan Gilbert > static void runstate_init(void) > { > const RunStateTransition *p; > -- > 2.4.3 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK