From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754906AbbFQXbN (ORCPT ); Wed, 17 Jun 2015 19:31:13 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:38562 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752997AbbFQXbJ (ORCPT ); Wed, 17 Jun 2015 19:31:09 -0400 Date: Thu, 18 Jun 2015 00:30:40 +0100 From: Russell King - ARM Linux To: Doug Anderson Cc: Philipp Zabel , Thierry Reding , Heiko Stuebner , David Airlie , Andy Yan , Yakir Yang , Fabio Estevam , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: bridge/dw_hdmi: Filter modes > 165MHz for DVI Message-ID: <20150617233040.GE7557@n2100.arm.linux.org.uk> References: <1434582847-713-1-git-send-email-dianders@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434582847-713-1-git-send-email-dianders@chromium.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 17, 2015 at 04:14:07PM -0700, Doug Anderson wrote: > If you plug in a DVI monitor to your HDMI port, you need to filter out > clocks > 165MHz. That's because 165MHz is the maximum clock rate that > we can run single-link DVI at. > > If you want to run high resolutions to DVI, you'd need some type of an > active adapter that pretended that it was HDMI, interpreted the > signal, and produced a new dual link DVI signal at a lower clock rate. > > Signed-off-by: Doug Anderson > --- > Note: this patch was tested against a 3.14 kernel with backports. It > was only compile tested against linuxnext, but the code is > sufficiently similar that I'm convinced it will work there. Really? I have to wonder what your testing was... hdmi->vic = drm_match_cea_mode(mode); if (!hdmi->vic) { dev_dbg(hdmi->dev, "Non-CEA mode used in HDMI\n"); hdmi->hdmi_data.video_mode.mdvi = true; } else { dev_dbg(hdmi->dev, "CEA mode used vic=%d\n", hdmi->vic); hdmi->hdmi_data.video_mode.mdvi = false; } mdvi indicates whether the _currently set mode_ is a CEA mode or not (imho, it's mis-named). It doesn't indicate whether we have a HDMI display device or a DVI display device connected, which seems to be what you want to use it for below. To sort that, what you need to do is detect a HDMI display device using drm_detect_hdmi_monitor() on the EDID received from the device before parsing the modes, and save that value in a dw_hdmi struct member, and I'd suggest that it's a top-level struct member, not buried in 'hdmi_data' or 'video_mode'. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH] drm: bridge/dw_hdmi: Filter modes > 165MHz for DVI Date: Thu, 18 Jun 2015 00:30:40 +0100 Message-ID: <20150617233040.GE7557@n2100.arm.linux.org.uk> References: <1434582847-713-1-git-send-email-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from pandora.arm.linux.org.uk (pandora.arm.linux.org.uk [78.32.30.218]) by gabe.freedesktop.org (Postfix) with ESMTP id B57726E45A for ; Wed, 17 Jun 2015 16:31:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1434582847-713-1-git-send-email-dianders@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Doug Anderson Cc: Fabio Estevam , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Yakir Yang , Andy Yan , Thierry Reding List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBKdW4gMTcsIDIwMTUgYXQgMDQ6MTQ6MDdQTSAtMDcwMCwgRG91ZyBBbmRlcnNvbiB3 cm90ZToKPiBJZiB5b3UgcGx1ZyBpbiBhIERWSSBtb25pdG9yIHRvIHlvdXIgSERNSSBwb3J0LCB5 b3UgbmVlZCB0byBmaWx0ZXIgb3V0Cj4gY2xvY2tzID4gMTY1TUh6LiAgVGhhdCdzIGJlY2F1c2Ug MTY1TUh6IGlzIHRoZSBtYXhpbXVtIGNsb2NrIHJhdGUgdGhhdAo+IHdlIGNhbiBydW4gc2luZ2xl LWxpbmsgRFZJIGF0Lgo+IAo+IElmIHlvdSB3YW50IHRvIHJ1biBoaWdoIHJlc29sdXRpb25zIHRv IERWSSwgeW91J2QgbmVlZCBzb21lIHR5cGUgb2YgYW4KPiBhY3RpdmUgYWRhcHRlciB0aGF0IHBy ZXRlbmRlZCB0aGF0IGl0IHdhcyBIRE1JLCBpbnRlcnByZXRlZCB0aGUKPiBzaWduYWwsIGFuZCBw cm9kdWNlZCBhIG5ldyBkdWFsIGxpbmsgRFZJIHNpZ25hbCBhdCBhIGxvd2VyIGNsb2NrIHJhdGUu Cj4gCj4gU2lnbmVkLW9mZi1ieTogRG91ZyBBbmRlcnNvbiA8ZGlhbmRlcnNAY2hyb21pdW0ub3Jn Pgo+IC0tLQo+IE5vdGU6IHRoaXMgcGF0Y2ggd2FzIHRlc3RlZCBhZ2FpbnN0IGEgMy4xNCBrZXJu ZWwgd2l0aCBiYWNrcG9ydHMuICBJdAo+IHdhcyBvbmx5IGNvbXBpbGUgdGVzdGVkIGFnYWluc3Qg bGludXhuZXh0LCBidXQgdGhlIGNvZGUgaXMKPiBzdWZmaWNpZW50bHkgc2ltaWxhciB0aGF0IEkn bSBjb252aW5jZWQgaXQgd2lsbCB3b3JrIHRoZXJlLgoKUmVhbGx5PyAgSSBoYXZlIHRvIHdvbmRl ciB3aGF0IHlvdXIgdGVzdGluZyB3YXMuLi4KCiAgICAgICAgaGRtaS0+dmljID0gZHJtX21hdGNo X2NlYV9tb2RlKG1vZGUpOwoKICAgICAgICBpZiAoIWhkbWktPnZpYykgewogICAgICAgICAgICAg ICAgZGV2X2RiZyhoZG1pLT5kZXYsICJOb24tQ0VBIG1vZGUgdXNlZCBpbiBIRE1JXG4iKTsKICAg ICAgICAgICAgICAgIGhkbWktPmhkbWlfZGF0YS52aWRlb19tb2RlLm1kdmkgPSB0cnVlOwogICAg ICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAgICBkZXZfZGJnKGhkbWktPmRldiwgIkNFQSBtb2Rl IHVzZWQgdmljPSVkXG4iLCBoZG1pLT52aWMpOwogICAgICAgICAgICAgICAgaGRtaS0+aGRtaV9k YXRhLnZpZGVvX21vZGUubWR2aSA9IGZhbHNlOwogICAgICAgIH0KCm1kdmkgaW5kaWNhdGVzIHdo ZXRoZXIgdGhlIF9jdXJyZW50bHkgc2V0IG1vZGVfIGlzIGEgQ0VBIG1vZGUgb3Igbm90IChpbWhv LAppdCdzIG1pcy1uYW1lZCkuICBJdCBkb2Vzbid0IGluZGljYXRlIHdoZXRoZXIgd2UgaGF2ZSBh IEhETUkgZGlzcGxheSBkZXZpY2UKb3IgYSBEVkkgZGlzcGxheSBkZXZpY2UgY29ubmVjdGVkLCB3 aGljaCBzZWVtcyB0byBiZSB3aGF0IHlvdSB3YW50IHRvIHVzZQppdCBmb3IgYmVsb3cuCgpUbyBz b3J0IHRoYXQsIHdoYXQgeW91IG5lZWQgdG8gZG8gaXMgZGV0ZWN0IGEgSERNSSBkaXNwbGF5IGRl dmljZSB1c2luZwpkcm1fZGV0ZWN0X2hkbWlfbW9uaXRvcigpIG9uIHRoZSBFRElEIHJlY2VpdmVk IGZyb20gdGhlIGRldmljZSBiZWZvcmUKcGFyc2luZyB0aGUgbW9kZXMsIGFuZCBzYXZlIHRoYXQg dmFsdWUgaW4gYSBkd19oZG1pIHN0cnVjdCBtZW1iZXIsIGFuZApJJ2Qgc3VnZ2VzdCB0aGF0IGl0 J3MgYSB0b3AtbGV2ZWwgc3RydWN0IG1lbWJlciwgbm90IGJ1cmllZCBpbiAnaGRtaV9kYXRhJwpv ciAndmlkZW9fbW9kZScuCgotLSAKRlRUQyBicm9hZGJhbmQgZm9yIDAuOG1pbGUgbGluZTogY3Vy cmVudGx5IGF0IDEwLjVNYnBzIGRvd24gNDAwa2JwcyB1cAphY2NvcmRpbmcgdG8gc3BlZWR0ZXN0 Lm5ldC4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK