From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5XLk-00020b-En for qemu-devel@nongnu.org; Thu, 18 Jun 2015 06:47:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5XLe-0006AS-U6 for qemu-devel@nongnu.org; Thu, 18 Jun 2015 06:47:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5XLe-0006AB-OJ for qemu-devel@nongnu.org; Thu, 18 Jun 2015 06:47:06 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 5ECB2BDD8B for ; Thu, 18 Jun 2015 10:47:06 +0000 (UTC) Date: Thu, 18 Jun 2015 11:47:02 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20150618104702.GG2248@work-vm> References: <1434505833-11234-1-git-send-email-quintela@redhat.com> <1434505833-11234-10-git-send-email-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434505833-11234-10-git-send-email-quintela@redhat.com> Subject: Re: [Qemu-devel] [PATCH 09/11] migration: No need to call trace_migrate_set_state() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: amit.shah@redhat.com, qemu-devel@nongnu.org * Juan Quintela (quintela@redhat.com) wrote: > We now use the helper everywhere, so no need to call this on this two > places. See on previous commit that there were a place where we missed > to mark the trace. Now all tracing is done in migrate_set_state(). Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: Juan Quintela > --- > migration/migration.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/migration/migration.c b/migration/migration.c > index 1c84249..b31c7f4 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -546,7 +546,6 @@ void migrate_fd_error(MigrationState *s) > trace_migrate_fd_error(); > assert(s->file == NULL); > migrate_set_state(s, MIGRATION_STATUS_SETUP, MIGRATION_STATUS_FAILED); > - trace_migrate_set_state(MIGRATION_STATUS_FAILED); > notifier_list_notify(&migration_state_notifiers, s); > } > > @@ -631,7 +630,6 @@ static MigrationState *migrate_init(const MigrationParams *params) > decompress_thread_count; > s->bandwidth_limit = bandwidth_limit; > migrate_set_state(s, MIGRATION_STATUS_NONE, MIGRATION_STATUS_SETUP); > - trace_migrate_set_state(MIGRATION_STATUS_SETUP); > > s->total_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME); > return s; > -- > 2.4.3 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK