From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756146AbbFRP4Y (ORCPT ); Thu, 18 Jun 2015 11:56:24 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:40704 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755100AbbFRP4I (ORCPT ); Thu, 18 Jun 2015 11:56:08 -0400 Date: Thu, 18 Jun 2015 16:55:45 +0100 From: Russell King - ARM Linux To: Doug Anderson Cc: Philipp Zabel , Thierry Reding , Heiko Stuebner , David Airlie , Andy Yan , Yakir Yang , Fabio Estevam , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] drm: bridge/dw_hdmi: Filter modes > 165MHz for DVI Message-ID: <20150618155545.GQ7557@n2100.arm.linux.org.uk> References: <1434582847-713-1-git-send-email-dianders@chromium.org> <20150617233040.GE7557@n2100.arm.linux.org.uk> <20150618085335.GF7557@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 18, 2015 at 08:26:39AM -0700, Doug Anderson wrote: > Russell, > > On Thu, Jun 18, 2015 at 1:53 AM, Russell King - ARM Linux > wrote: > >> OK, so clearly my patch won't work against mainline. I guess it's a > >> good thing that I pointed out that it was only tested locally (would > >> have been better to test against mainline, but I don't think that's so > >> easy since there are several unlanded patches in mainline for > >> Rockchip). > > > > As far as I'm aware, Freescale's original BSP version was the same, as is > > their later BSPs, and Jon's maintained 3.14-stable kernel. > > Was "the same"? You mean was untested, or was 3.14? I'm saying that the mdvi thing behaves the same in all the kernel sources I've seen of this driver, and I'm unaware of anything that changes it - and I've been looking at Jon's 3.14-stable kernels as well as Freescale's git repository. > >> As pointed out by others at , locally > >> our kernel has a slightly older version of > >> , which would change mdvi to be > >> as needed. > > > > Please don't post unreliable lkml.org URLs, please use some other archive > > site. I can't access this URL at the moment. > > Perhaps you can try Something like that needs to be done, but let's get rid of the mdvi thing in struct hdmi_vmode - it doesn't belong there, it isn't part of the currently set video mode, but becomes a property of the connected sink. I'd also prefer it to be called "is_dvi_sink", especially as its function is changing from "is it a CEA mode" to "is the attached device a DVI sink". Even better would be to call it "is_hdmi_sink" to maintain positive logic with single-negation where required, rather than double- negation in places. > >> ...so I guess my change is blocked on someone reviewing/landing that > >> series. If that series is rejected (or is changed sufficiently so > >> that mdvi no longer is set via drm_detect_hdmi_monitor() then my patch > >> will need to be re-spun. > > > > That's not what I said. I said mdvi is set according to whether the mode > > being set is a CEA mode or not. > > Perhaps now that you can access the patch with the patchwork link you > can re-read my email. If/when that patch lands then mdvi _will_ be > set as per drm_detect_hdmi_monitor(). Well, I object to that patch (see above.) > I am nowhere near an HDMI expert. If you have a better suggestion > then I'm more than happy for you to post it and drop my patch. In my > non-expert opinion, it would seem awfully strange for an AV receiver > to modify the EDID though unless it was actively interpreting the > signal and generating a whole new signal on the other end. In any > case, perhaps you can find such a device and that will give insight to > how we should deal with it. Until such a device is found, it seems > fruitless to speculate. Neither am I, but I have had the ability to do some testing with AV receivers in the path of a HDMI device, and I've seen how they behave. (I made copious notes on this, which I intend to publish when I have a round tuit.) Unfortunately, I have no DVI devices to test with, and DVI devices are a dying breed - most monitors today come with HDMI sockets instead. > Personally, I was pointed at "drivers/gpu/drm/i915/intel_hdmi.c". If > you look there you will find a similar bit of code. Yea, I've also been using that for inspiration too, but I put personal testing above what's in someone elses driver. :) > To summarize: I am not planning to spin my patch. I am hopeful that > folks could review Yakir's series. Would it help if he re-sent it > with different people in the "To" line? That's a shame... I'm not inclined to Ack it as-is - and I'd also like to see Yakir's patch reworked as I mentioned above. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH] drm: bridge/dw_hdmi: Filter modes > 165MHz for DVI Date: Thu, 18 Jun 2015 16:55:45 +0100 Message-ID: <20150618155545.GQ7557@n2100.arm.linux.org.uk> References: <1434582847-713-1-git-send-email-dianders@chromium.org> <20150617233040.GE7557@n2100.arm.linux.org.uk> <20150618085335.GF7557@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from pandora.arm.linux.org.uk (pandora.arm.linux.org.uk [78.32.30.218]) by gabe.freedesktop.org (Postfix) with ESMTP id 75C716E23A for ; Thu, 18 Jun 2015 08:56:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Doug Anderson Cc: Fabio Estevam , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Yakir Yang , Andy Yan , Thierry Reding List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdW4gMTgsIDIwMTUgYXQgMDg6MjY6MzlBTSAtMDcwMCwgRG91ZyBBbmRlcnNvbiB3 cm90ZToKPiBSdXNzZWxsLAo+IAo+IE9uIFRodSwgSnVuIDE4LCAyMDE1IGF0IDE6NTMgQU0sIFJ1 c3NlbGwgS2luZyAtIEFSTSBMaW51eAo+IDxsaW51eEBhcm0ubGludXgub3JnLnVrPiB3cm90ZToK PiA+PiBPSywgc28gY2xlYXJseSBteSBwYXRjaCB3b24ndCB3b3JrIGFnYWluc3QgbWFpbmxpbmUu ICBJIGd1ZXNzIGl0J3MgYQo+ID4+IGdvb2QgdGhpbmcgdGhhdCBJIHBvaW50ZWQgb3V0IHRoYXQg aXQgd2FzIG9ubHkgdGVzdGVkIGxvY2FsbHkgKHdvdWxkCj4gPj4gaGF2ZSBiZWVuIGJldHRlciB0 byB0ZXN0IGFnYWluc3QgbWFpbmxpbmUsIGJ1dCBJIGRvbid0IHRoaW5rIHRoYXQncyBzbwo+ID4+ IGVhc3kgc2luY2UgdGhlcmUgYXJlIHNldmVyYWwgdW5sYW5kZWQgcGF0Y2hlcyBpbiBtYWlubGlu ZSBmb3IKPiA+PiBSb2NrY2hpcCkuCj4gPgo+ID4gQXMgZmFyIGFzIEknbSBhd2FyZSwgRnJlZXNj YWxlJ3Mgb3JpZ2luYWwgQlNQIHZlcnNpb24gd2FzIHRoZSBzYW1lLCBhcyBpcwo+ID4gdGhlaXIg bGF0ZXIgQlNQcywgYW5kIEpvbidzIG1haW50YWluZWQgMy4xNC1zdGFibGUga2VybmVsLgo+IAo+ IFdhcyAidGhlIHNhbWUiPyAgWW91IG1lYW4gd2FzIHVudGVzdGVkLCBvciB3YXMgMy4xND8KCkkn bSBzYXlpbmcgdGhhdCB0aGUgbWR2aSB0aGluZyBiZWhhdmVzIHRoZSBzYW1lIGluIGFsbCB0aGUg a2VybmVsIHNvdXJjZXMKSSd2ZSBzZWVuIG9mIHRoaXMgZHJpdmVyLCBhbmQgSSdtIHVuYXdhcmUg b2YgYW55dGhpbmcgdGhhdCBjaGFuZ2VzIGl0IC0KYW5kIEkndmUgYmVlbiBsb29raW5nIGF0IEpv bidzIDMuMTQtc3RhYmxlIGtlcm5lbHMgYXMgd2VsbCBhcyBGcmVlc2NhbGUncwpnaXQgcmVwb3Np dG9yeS4KCj4gPj4gQXMgcG9pbnRlZCBvdXQgYnkgb3RoZXJzIGF0IDxodHRwOi8vY3Jvc3Jldmll dy5jb20vMjc4MjU1PiwgbG9jYWxseQo+ID4+IG91ciBrZXJuZWwgaGFzIGEgc2xpZ2h0bHkgb2xk ZXIgdmVyc2lvbiBvZgo+ID4+IDxodHRwczovL2xrbWwub3JnL2xrbWwvMjAxNS8yLzI4LzI5MT4s IHdoaWNoIHdvdWxkIGNoYW5nZSBtZHZpIHRvIGJlCj4gPj4gYXMgbmVlZGVkLgo+ID4KPiA+IFBs ZWFzZSBkb24ndCBwb3N0IHVucmVsaWFibGUgbGttbC5vcmcgVVJMcywgcGxlYXNlIHVzZSBzb21l IG90aGVyIGFyY2hpdmUKPiA+IHNpdGUuICBJIGNhbid0IGFjY2VzcyB0aGlzIFVSTCBhdCB0aGUg bW9tZW50Lgo+IAo+IFBlcmhhcHMgeW91IGNhbiB0cnkgPGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5l bC5vcmcvcGF0Y2gvNTkwNjc3MS8+CgpTb21ldGhpbmcgbGlrZSB0aGF0IG5lZWRzIHRvIGJlIGRv bmUsIGJ1dCBsZXQncyBnZXQgcmlkIG9mIHRoZSBtZHZpCnRoaW5nIGluIHN0cnVjdCBoZG1pX3Zt b2RlIC0gaXQgZG9lc24ndCBiZWxvbmcgdGhlcmUsIGl0IGlzbid0IHBhcnQKb2YgdGhlIGN1cnJl bnRseSBzZXQgdmlkZW8gbW9kZSwgYnV0IGJlY29tZXMgYSBwcm9wZXJ0eSBvZiB0aGUKY29ubmVj dGVkIHNpbmsuCgpJJ2QgYWxzbyBwcmVmZXIgaXQgdG8gYmUgY2FsbGVkICJpc19kdmlfc2luayIs IGVzcGVjaWFsbHkgYXMgaXRzCmZ1bmN0aW9uIGlzIGNoYW5naW5nIGZyb20gImlzIGl0IGEgQ0VB IG1vZGUiIHRvICJpcyB0aGUgYXR0YWNoZWQKZGV2aWNlIGEgRFZJIHNpbmsiLgoKRXZlbiBiZXR0 ZXIgd291bGQgYmUgdG8gY2FsbCBpdCAiaXNfaGRtaV9zaW5rIiB0byBtYWludGFpbiBwb3NpdGl2 ZQpsb2dpYyB3aXRoIHNpbmdsZS1uZWdhdGlvbiB3aGVyZSByZXF1aXJlZCwgcmF0aGVyIHRoYW4g ZG91YmxlLQpuZWdhdGlvbiBpbiBwbGFjZXMuCgo+ID4+IC4uLnNvIEkgZ3Vlc3MgbXkgY2hhbmdl IGlzIGJsb2NrZWQgb24gc29tZW9uZSByZXZpZXdpbmcvbGFuZGluZyB0aGF0Cj4gPj4gc2VyaWVz LiAgSWYgdGhhdCBzZXJpZXMgaXMgcmVqZWN0ZWQgKG9yIGlzIGNoYW5nZWQgc3VmZmljaWVudGx5 IHNvCj4gPj4gdGhhdCBtZHZpIG5vIGxvbmdlciBpcyBzZXQgdmlhIGRybV9kZXRlY3RfaGRtaV9t b25pdG9yKCkgdGhlbiBteSBwYXRjaAo+ID4+IHdpbGwgbmVlZCB0byBiZSByZS1zcHVuLgo+ID4K PiA+IFRoYXQncyBub3Qgd2hhdCBJIHNhaWQuICBJIHNhaWQgbWR2aSBpcyBzZXQgYWNjb3JkaW5n IHRvIHdoZXRoZXIgdGhlIG1vZGUKPiA+IGJlaW5nIHNldCBpcyBhIENFQSBtb2RlIG9yIG5vdC4K PiAKPiBQZXJoYXBzIG5vdyB0aGF0IHlvdSBjYW4gYWNjZXNzIHRoZSBwYXRjaCB3aXRoIHRoZSBw YXRjaHdvcmsgbGluayB5b3UKPiBjYW4gcmUtcmVhZCBteSBlbWFpbC4gIElmL3doZW4gdGhhdCBw YXRjaCBsYW5kcyB0aGVuIG1kdmkgX3dpbGxfIGJlCj4gc2V0IGFzIHBlciBkcm1fZGV0ZWN0X2hk bWlfbW9uaXRvcigpLgoKV2VsbCwgSSBvYmplY3QgdG8gdGhhdCBwYXRjaCAoc2VlIGFib3ZlLikK Cj4gSSBhbSBub3doZXJlIG5lYXIgYW4gSERNSSBleHBlcnQuICBJZiB5b3UgaGF2ZSBhIGJldHRl ciBzdWdnZXN0aW9uCj4gdGhlbiBJJ20gbW9yZSB0aGFuIGhhcHB5IGZvciB5b3UgdG8gcG9zdCBp dCBhbmQgZHJvcCBteSBwYXRjaC4gIEluIG15Cj4gbm9uLWV4cGVydCBvcGluaW9uLCBpdCB3b3Vs ZCBzZWVtIGF3ZnVsbHkgc3RyYW5nZSBmb3IgYW4gQVYgcmVjZWl2ZXIKPiB0byBtb2RpZnkgdGhl IEVESUQgdGhvdWdoIHVubGVzcyBpdCB3YXMgYWN0aXZlbHkgaW50ZXJwcmV0aW5nIHRoZQo+IHNp Z25hbCBhbmQgZ2VuZXJhdGluZyBhIHdob2xlIG5ldyBzaWduYWwgb24gdGhlIG90aGVyIGVuZC4g IEluIGFueQo+IGNhc2UsIHBlcmhhcHMgeW91IGNhbiBmaW5kIHN1Y2ggYSBkZXZpY2UgYW5kIHRo YXQgd2lsbCBnaXZlIGluc2lnaHQgdG8KPiBob3cgd2Ugc2hvdWxkIGRlYWwgd2l0aCBpdC4gIFVu dGlsIHN1Y2ggYSBkZXZpY2UgaXMgZm91bmQsIGl0IHNlZW1zCj4gZnJ1aXRsZXNzIHRvIHNwZWN1 bGF0ZS4KCk5laXRoZXIgYW0gSSwgYnV0IEkgaGF2ZSBoYWQgdGhlIGFiaWxpdHkgdG8gZG8gc29t ZSB0ZXN0aW5nIHdpdGggQVYKcmVjZWl2ZXJzIGluIHRoZSBwYXRoIG9mIGEgSERNSSBkZXZpY2Us IGFuZCBJJ3ZlIHNlZW4gaG93IHRoZXkgYmVoYXZlLgooSSBtYWRlIGNvcGlvdXMgbm90ZXMgb24g dGhpcywgd2hpY2ggSSBpbnRlbmQgdG8gcHVibGlzaCB3aGVuIEkgaGF2ZQphIHJvdW5kIHR1aXQu KSAgVW5mb3J0dW5hdGVseSwgSSBoYXZlIG5vIERWSSBkZXZpY2VzIHRvIHRlc3Qgd2l0aCwKYW5k IERWSSBkZXZpY2VzIGFyZSBhIGR5aW5nIGJyZWVkIC0gbW9zdCBtb25pdG9ycyB0b2RheSBjb21l IHdpdGgKSERNSSBzb2NrZXRzIGluc3RlYWQuCgo+IFBlcnNvbmFsbHksIEkgd2FzIHBvaW50ZWQg YXQgImRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2hkbWkuYyIuICBJZgo+IHlvdSBsb29rIHRo ZXJlIHlvdSB3aWxsIGZpbmQgYSBzaW1pbGFyIGJpdCBvZiBjb2RlLgoKWWVhLCBJJ3ZlIGFsc28g YmVlbiB1c2luZyB0aGF0IGZvciBpbnNwaXJhdGlvbiB0b28sIGJ1dCBJIHB1dCBwZXJzb25hbAp0 ZXN0aW5nIGFib3ZlIHdoYXQncyBpbiBzb21lb25lIGVsc2VzIGRyaXZlci4gOikKCj4gVG8gc3Vt bWFyaXplOiBJIGFtIG5vdCBwbGFubmluZyB0byBzcGluIG15IHBhdGNoLiAgSSBhbSBob3BlZnVs IHRoYXQKPiBmb2xrcyBjb3VsZCByZXZpZXcgWWFraXIncyBzZXJpZXMuICBXb3VsZCBpdCBoZWxw IGlmIGhlIHJlLXNlbnQgaXQKPiB3aXRoIGRpZmZlcmVudCBwZW9wbGUgaW4gdGhlICJUbyIgbGlu ZT8KClRoYXQncyBhIHNoYW1lLi4uIEknbSBub3QgaW5jbGluZWQgdG8gQWNrIGl0IGFzLWlzIC0g YW5kIEknZCBhbHNvIGxpa2UKdG8gc2VlIFlha2lyJ3MgcGF0Y2ggcmV3b3JrZWQgYXMgSSBtZW50 aW9uZWQgYWJvdmUuCgotLSAKRlRUQyBicm9hZGJhbmQgZm9yIDAuOG1pbGUgbGluZTogY3VycmVu dGx5IGF0IDEwLjVNYnBzIGRvd24gNDAwa2JwcyB1cAphY2NvcmRpbmcgdG8gc3BlZWR0ZXN0Lm5l dC4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK