From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756516AbbFRQ0e (ORCPT ); Thu, 18 Jun 2015 12:26:34 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:36392 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754679AbbFRQ0c (ORCPT ); Thu, 18 Jun 2015 12:26:32 -0400 Date: Thu, 18 Jun 2015 18:26:27 +0200 From: Ingo Molnar To: Martin =?utf-8?B?TGnFoWth?= Cc: linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Paul Mackerras , Andi Kleen Subject: Re: [PATCH] perf annotate: With --show-total-period, display total # of samples. Message-ID: <20150618162627.GB6989@gmail.com> References: <5582ED6D.4010707@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5582ED6D.4010707@suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Martin Liška wrote: > To compare two records on an instruction base, with --show-total-period > option provided, display total number of samples that belong to a line > in assembly language. > > Signed-off-by: Martin Liska > --- > tools/perf/builtin-annotate.c | 2 ++ > tools/perf/ui/browsers/annotate.c | 44 +++++++++++++++++++++++++-------------- > tools/perf/util/annotate.c | 28 +++++++++++++++++++------ > tools/perf/util/annotate.h | 3 ++- > 4 files changed, 54 insertions(+), 23 deletions(-) > > diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c > index 4e08c2d..2c1bec3 100644 > --- a/tools/perf/builtin-annotate.c > +++ b/tools/perf/builtin-annotate.c > @@ -329,6 +329,8 @@ int cmd_annotate(int argc, const char **argv, const char *prefix __maybe_unused) > "objdump binary to use for disassembly and annotations"), > OPT_BOOLEAN(0, "group", &symbol_conf.event_group, > "Show event group information together"), > + OPT_BOOLEAN(0, "show-total-period", &symbol_conf.show_total_period, > + "Show a column with the sum of periods"), > OPT_END() What is the toggle for this in the 'perf report' TUI? (which displays annotated output too) Thanks, Ingo