All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, fw@strlen.de, eric.dumazet@gmail.com
Subject: Re: [PATCH nf-next 2/2] netfilter: nft_counter: add per-cpu support
Date: Fri, 19 Jun 2015 11:22:39 +0200	[thread overview]
Message-ID: <20150619092239.GB22946@acer.localdomain> (raw)
In-Reply-To: <20150619092503.GA11247@salvia>

On 19.06, Pablo Neira Ayuso wrote:
> On Fri, Jun 19, 2015 at 12:25:30AM +0200, Patrick McHardy wrote:
> > On 18.06, Pablo Neira Ayuso wrote:
> > > This patch adds rule per-cpu counters. This introduces a new NFTA_COUNTER_TYPE
> > > netlink attribute to indicate the type of counters to be used. The default is
> > > the compact seqlock representation for compatibility.
> > 
> > I don't think that userspace should care about the implementation details.
> > I'd just switch to percpu unconditionally.
> 
> Will send a v2.
> 
> I can't find a use-case for the compact memory representation of the
> seqlock counter, but if that ever happens we can go back to this type
> attribute so the user can select.

I agree. Thanks!

      reply	other threads:[~2015-06-19  9:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-18 18:21 [PATCH nf-next 1/2] netfilter: nft_counter: split out counters from nft_counter Pablo Neira Ayuso
2015-06-18 18:21 ` [PATCH nf-next 2/2] netfilter: nft_counter: add per-cpu support Pablo Neira Ayuso
2015-06-18 22:25   ` Patrick McHardy
2015-06-19  9:25     ` Pablo Neira Ayuso
2015-06-19  9:22       ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150619092239.GB22946@acer.localdomain \
    --to=kaber@trash.net \
    --cc=eric.dumazet@gmail.com \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.