From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 801851C2D39 for ; Fri, 19 Jun 2015 12:55:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 79F252FD66 for ; Fri, 19 Jun 2015 12:55:46 +0000 (UTC) Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bkFWiQWwq0Pq for ; Fri, 19 Jun 2015 12:55:45 +0000 (UTC) Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by silver.osuosl.org (Postfix) with ESMTPS id 7AC782E7E6 for ; Fri, 19 Jun 2015 12:55:45 +0000 (UTC) Date: Fri, 19 Jun 2015 15:55:14 +0300 From: Dan Carpenter Subject: Re: [PATCH v2 2/3] staging: unisys: convert pack pragma to __packed Message-ID: <20150619125513.GP28762@mwanda> References: <1434141968-4133-1-git-send-email-david.kershner@unisys.com> <1434141968-4133-3-git-send-email-david.kershner@unisys.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1434141968-4133-3-git-send-email-david.kershner@unisys.com> List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: David Kershner Cc: gregkh@linuxfoundation.org, Benjamin.Romer@unisys.com, sParMaintainer@unisys.com, driverdev-devel@linuxdriverproject.org, Jes.Sorensen@redhat.com On Fri, Jun 12, 2015 at 04:46:07PM -0400, David Kershner wrote: > It was noticed that iochannel.h was still using pragmas to > pack the datastructures, should be using __packed instead. > > Signed-off-by: David Kershner Could you take some time and figure out which structs should actually be packed and which should not? For example, in net_pkt_rcv the pointers are not aligned so it will cause a slow down on x86 and crash on other arches (which we don't care about). regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel