From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755803AbbFUQKp (ORCPT ); Sun, 21 Jun 2015 12:10:45 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:46302 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751909AbbFUQKg (ORCPT ); Sun, 21 Jun 2015 12:10:36 -0400 Date: Sun, 21 Jun 2015 09:22:18 -0700 (PDT) Message-Id: <20150621.092218.2158342160706463595.davem@davemloft.net> To: noamc@ezchip.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey.Brodkin@synopsys.com, vgupta@synopsys.com, giladb@ezchip.com, cmetcalf@ezchip.com, talz@ezchip.com Subject: Re: [PATCH v5] NET: Add ezchip ethernet driver From: David Miller In-Reply-To: <1434465342-7412-1-git-send-email-noamc@ezchip.com> References: <1434263193-16877-1-git-send-email-noamc@ezchip.com> <1434465342-7412-1-git-send-email-noamc@ezchip.com> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 21 Jun 2015 09:10:35 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t5LGAs8T001472 From: Noam Camus Date: Tue, 16 Jun 2015 17:35:42 +0300 > From: Noam Camus > > Simple LAN device for debug or management purposes. > Device supports interrupts for RX and TX(completion). > Device does not have DMA ability. > > Signed-off-by: Noam Camus > Signed-off-by: Tal Zilcer > Acked-by: Alexey Brodkin This builds with several warnings and also doesn't compile. drivers/net/ethernet/ezchip/nps_enet.c: In function ”nps_enet_read_rx_fifo¢: drivers/net/ethernet/ezchip/nps_enet.c:43:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] drivers/net/ethernet/ezchip/nps_enet.c:43:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] drivers/net/ethernet/ezchip/nps_enet.c: In function ”nps_enet_send_frame¢: drivers/net/ethernet/ezchip/nps_enet.c:366:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] drivers/net/ethernet/ezchip/nps_enet.c:366:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] drivers/net/ethernet/ezchip/nps_enet.c: In function ”nps_enet_poll_controller¢: drivers/net/ethernet/ezchip/nps_enet.c:535:2: error: implicit declaration of function ”nps_enet_board_irq_handler¢ [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors I do not even see where npe_enet_board_irq_handler could possible be defined. It is quite infuriating to receive a patch like this which is claimed to be complete and ready to be applied to my tree, yet it is very clearly not. ’ōčŗ{.nĒ+‰·Ÿ®‰­†+%ŠĖ’±éŻ¶„Šw’ŗ{.nĒ+‰·„Š{±žG«é’Šsåy«­ę¶…­†Ūi’’šĆķ»č®å’i From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v5] NET: Add ezchip ethernet driver Date: Sun, 21 Jun 2015 09:22:18 -0700 (PDT) Message-ID: <20150621.092218.2158342160706463595.davem@davemloft.net> References: <1434263193-16877-1-git-send-email-noamc@ezchip.com> <1434465342-7412-1-git-send-email-noamc@ezchip.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 Content-Transfer-Encoding: base64 Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey.Brodkin@synopsys.com, vgupta@synopsys.com, giladb@ezchip.com, cmetcalf@ezchip.com, talz@ezchip.com To: noamc@ezchip.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:46302 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751909AbbFUQKg (ORCPT ); Sun, 21 Jun 2015 12:10:36 -0400 In-Reply-To: <1434465342-7412-1-git-send-email-noamc@ezchip.com> Sender: netdev-owner@vger.kernel.org List-ID: RnJvbTogTm9hbSBDYW11cyA8bm9hbWNAZXpjaGlwLmNvbT4NCkRhdGU6IFR1ZSwgMTYgSnVuIDIw MTUgMTc6MzU6NDIgKzAzMDANCg0KPiBGcm9tOiBOb2FtIENhbXVzIDxub2FtY0BlemNoaXAuY29t Pg0KPiANCj4gU2ltcGxlIExBTiBkZXZpY2UgZm9yIGRlYnVnIG9yIG1hbmFnZW1lbnQgcHVycG9z ZXMuDQo+IERldmljZSBzdXBwb3J0cyBpbnRlcnJ1cHRzIGZvciBSWCBhbmQgVFgoY29tcGxldGlv bikuDQo+IERldmljZSBkb2VzIG5vdCBoYXZlIERNQSBhYmlsaXR5Lg0KPiANCj4gU2lnbmVkLW9m Zi1ieTogTm9hbSBDYW11cyA8bm9hbWNAZXpjaGlwLmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogVGFs IFppbGNlciA8dGFsekBlemNoaXAuY29tPg0KPiBBY2tlZC1ieTogQWxleGV5IEJyb2RraW4gPGFi cm9ka2luQHN5bm9wc3lzLmNvbT4NCg0KVGhpcyBidWlsZHMgd2l0aCBzZXZlcmFsIHdhcm5pbmdz IGFuZCBhbHNvIGRvZXNuJ3QgY29tcGlsZS4NCg0KZHJpdmVycy9uZXQvZXRoZXJuZXQvZXpjaGlw L25wc19lbmV0LmM6IEluIGZ1bmN0aW9uIKFucHNfZW5ldF9yZWFkX3J4X2ZpZm+iOg0KZHJpdmVy cy9uZXQvZXRoZXJuZXQvZXpjaGlwL25wc19lbmV0LmM6NDM6MjQ6IHdhcm5pbmc6IGNhc3QgZnJv bSBwb2ludGVyIHRvIGludGVnZXIgb2YgZGlmZmVyZW50IHNpemUgWy1XcG9pbnRlci10by1pbnQt Y2FzdF0NCmRyaXZlcnMvbmV0L2V0aGVybmV0L2V6Y2hpcC9ucHNfZW5ldC5jOjQzOjI0OiB3YXJu aW5nOiBjYXN0IGZyb20gcG9pbnRlciB0byBpbnRlZ2VyIG9mIGRpZmZlcmVudCBzaXplIFstV3Bv aW50ZXItdG8taW50LWNhc3RdDQpkcml2ZXJzL25ldC9ldGhlcm5ldC9lemNoaXAvbnBzX2VuZXQu YzogSW4gZnVuY3Rpb24goW5wc19lbmV0X3NlbmRfZnJhbWWiOg0KZHJpdmVycy9uZXQvZXRoZXJu ZXQvZXpjaGlwL25wc19lbmV0LmM6MzY2OjI0OiB3YXJuaW5nOiBjYXN0IGZyb20gcG9pbnRlciB0 byBpbnRlZ2VyIG9mIGRpZmZlcmVudCBzaXplIFstV3BvaW50ZXItdG8taW50LWNhc3RdDQpkcml2 ZXJzL25ldC9ldGhlcm5ldC9lemNoaXAvbnBzX2VuZXQuYzozNjY6MjQ6IHdhcm5pbmc6IGNhc3Qg ZnJvbSBwb2ludGVyIHRvIGludGVnZXIgb2YgZGlmZmVyZW50IHNpemUgWy1XcG9pbnRlci10by1p bnQtY2FzdF0NCmRyaXZlcnMvbmV0L2V0aGVybmV0L2V6Y2hpcC9ucHNfZW5ldC5jOiBJbiBmdW5j dGlvbiChbnBzX2VuZXRfcG9sbF9jb250cm9sbGVyojoNCmRyaXZlcnMvbmV0L2V0aGVybmV0L2V6 Y2hpcC9ucHNfZW5ldC5jOjUzNToyOiBlcnJvcjogaW1wbGljaXQgZGVjbGFyYXRpb24gb2YgZnVu Y3Rpb24goW5wc19lbmV0X2JvYXJkX2lycV9oYW5kbGVyoiBbLVdlcnJvcj1pbXBsaWNpdC1mdW5j dGlvbi1kZWNsYXJhdGlvbl0NCmNjMTogc29tZSB3YXJuaW5ncyBiZWluZyB0cmVhdGVkIGFzIGVy cm9ycw0KDQpJIGRvIG5vdCBldmVuIHNlZSB3aGVyZSBucGVfZW5ldF9ib2FyZF9pcnFfaGFuZGxl ciBjb3VsZCBwb3NzaWJsZSBiZSBkZWZpbmVkLg0KDQpJdCBpcyBxdWl0ZSBpbmZ1cmlhdGluZyB0 byByZWNlaXZlIGEgcGF0Y2ggbGlrZSB0aGlzIHdoaWNoIGlzIGNsYWltZWQNCnRvIGJlIGNvbXBs ZXRlIGFuZCByZWFkeSB0byBiZSBhcHBsaWVkIHRvIG15IHRyZWUsIHlldCBpdCBpcyB2ZXJ5DQpj bGVhcmx5IG5vdC4NCg==