From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756091AbbFUQnm (ORCPT ); Sun, 21 Jun 2015 12:43:42 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:46599 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751775AbbFUQnc (ORCPT ); Sun, 21 Jun 2015 12:43:32 -0400 Date: Sun, 21 Jun 2015 09:55:17 -0700 (PDT) Message-Id: <20150621.095517.1714979384853036107.davem@davemloft.net> To: fransklaver@gmail.com Cc: al.drozdov@gmail.com, maninder1.s@samsung.com, willemb@google.com, dborkman@redhat.com, viro@zeniv.linux.org.uk, eyal.birger@gmail.com, mst@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, pankaj.m@samsung.com Subject: Re: [RESUBMIT Patch 1/1] net: replace if()/BUG with BUG_ON From: David Miller In-Reply-To: References: <55812F32.5030306@gmail.com> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 21 Jun 2015 09:43:32 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frans Klaver Date: Wed, 17 Jun 2015 10:30:18 +0200 > Ah, that explains something. If retire timer is not going to be needed > for tx, wouldn't it be better to remove the whole tx_ring handling > from this function altogether, rather than changing the BUG()? Agreed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [RESUBMIT Patch 1/1] net: replace if()/BUG with BUG_ON Date: Sun, 21 Jun 2015 09:55:17 -0700 (PDT) Message-ID: <20150621.095517.1714979384853036107.davem@davemloft.net> References: <55812F32.5030306@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: al.drozdov@gmail.com, maninder1.s@samsung.com, willemb@google.com, dborkman@redhat.com, viro@zeniv.linux.org.uk, eyal.birger@gmail.com, mst@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, pankaj.m@samsung.com To: fransklaver@gmail.com Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Frans Klaver Date: Wed, 17 Jun 2015 10:30:18 +0200 > Ah, that explains something. If retire timer is not going to be needed > for tx, wouldn't it be better to remove the whole tx_ring handling > from this function altogether, rather than changing the BUG()? Agreed.