All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: [PATCH] net: inet_diag: export IPV6_V6ONLY sockopt
Date: Sun, 21 Jun 2015 03:47:39 +0200	[thread overview]
Message-ID: <20150621014739.GA18664@orbit.nwl.cc> (raw)
In-Reply-To: <1434721920.31511.16.camel@edumazet-glaptop2.roam.corp.google.com>

On Fri, Jun 19, 2015 at 06:52:00AM -0700, Eric Dumazet wrote:
> On Fri, 2015-06-19 at 14:15 +0200, Phil Sutter wrote:
> > For AF_INET6 sockets, the value of struct ipv6_pinfo.ipv6only is
> > exported to userspace. It indicates whether an unbound socket listens on
> > IPv4 as well as IPv6.
> 
> What is an 'unbound socket' ??? This makes no sense to me here.

Indeed, this is just plain wrong. Actually meant "not bound to a
specific IPv6 address".

> >  Since the socket is natively IPv6, it is not
> > listed by e.g. 'netstat -l -4'.
> 
> netstat does not use this interface. iproute2/ss does.

Just used this as a simple example illustrating the problem, but doing
the same with 'ss' is truly a better choice.

[...]

> 1) This certainly should not compile on current linux trees.
>    Always submit such patches on net-next.

It cleanly applies to net.git.

> 2) It is not clear why we would add this attribute if it is 0.
>     This looks a waste of data.
> 
> So I would rather use :

ACK. Thanks for reviewing, v2 follows after I've tested it.

Cheers, Phil

  reply	other threads:[~2015-06-21  1:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-15 20:54 netstat and dual stack sockets Phil Sutter
2015-06-15 21:36 ` Hagen Paul Pfeifer
2015-06-16  1:25   ` Phil Sutter
2015-06-19 12:15 ` [PATCH] net: inet_diag: export IPV6_V6ONLY sockopt Phil Sutter
2015-06-19 13:52   ` Eric Dumazet
2015-06-21  1:47     ` Phil Sutter [this message]
2015-06-21  8:52       ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150621014739.GA18664@orbit.nwl.cc \
    --to=phil@nwl.cc \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.