From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45152)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Z72Uu-0006tx-CF
	for qemu-devel@nongnu.org; Mon, 22 Jun 2015 10:14:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Z72Ut-0004is-Ie
	for qemu-devel@nongnu.org; Mon, 22 Jun 2015 10:14:52 -0400
Date: Mon, 22 Jun 2015 15:14:44 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20150622141444.GC7136@stefanha-thinkpad.redhat.com>
References: <1434765047-29333-1-git-send-email-jsnow@redhat.com>
	<1434765047-29333-7-git-send-email-jsnow@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="eHhjakXzOLJAF9wJ"
Content-Disposition: inline
In-Reply-To: <1434765047-29333-7-git-send-email-jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 06/16] ahci: add ncq debug checks
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org


--eHhjakXzOLJAF9wJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 19, 2015 at 09:50:37PM -0400, John Snow wrote:
> @@ -1003,6 +1003,27 @@ static void process_ncq_command(AHCIState *s, int =
port, uint8_t *cmd_fis,
>                     (uint64_t)ncq_fis->lba0;
>      ncq_tfs->tag =3D tag;
> =20
> +#ifdef DEBUG_AHCI

These sorts of debug ifdefs have a tendency to bitrot since the code
isn't compiled.

There is no need for the ifdef since DPRINTF() is deadcode when DEBUG_AHCI
is 0.  The compiler parses the code, preventing bitrot, but optimizes
the code away when DEBUG_ACHI is 0.

--eHhjakXzOLJAF9wJ
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJViBhUAAoJEJykq7OBq3PI8fgIAIAcpVA4ddFmGrxZ798cOhip
5xvTIn28HOQtAQSdexcr/DSCvnRVXU3IbcRvarWoUCfj+PfaKiHBVWpJKNry3u7B
dPssKgZ3QbRydo+W9GaBgSOu6O8aAq34TMYW88KacyjeBQ8giU+jXKn5ZnOfYQpj
H6ylFjpKq/pD37KocjjW6yXnkw90zRHRUUW/yO+fafboBpasTq6n+yf0x6LvjzGL
jXV3qEsXM+hfvJXJJe0IX0icsn3TPKxHVHHffo0ffffDS1d0wITbB/2oA8wCW6zq
A+0T97FuyoYWX70T5hKPn2GwF7VgIfeCIhtPu6hR78Yt8xlTxlCkr8itG7IAFXg=
=Vsms
-----END PGP SIGNATURE-----

--eHhjakXzOLJAF9wJ--