From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45711)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Z72Wi-0007tV-5b
	for qemu-devel@nongnu.org; Mon, 22 Jun 2015 10:16:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Z72We-0005hK-Fy
	for qemu-devel@nongnu.org; Mon, 22 Jun 2015 10:16:44 -0400
Date: Mon, 22 Jun 2015 15:16:33 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20150622141633.GD7136@stefanha-thinkpad.redhat.com>
References: <1434765047-29333-1-git-send-email-jsnow@redhat.com>
	<1434765047-29333-5-git-send-email-jsnow@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="+KJYzRxRHjYqLGl5"
Content-Disposition: inline
In-Reply-To: <1434765047-29333-5-git-send-email-jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 04/16] ahci: check for ncq prdtl overflow
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org


--+KJYzRxRHjYqLGl5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jun 19, 2015 at 09:50:35PM -0400, John Snow wrote:
> -    /* Note: We calculate the sector count, but don't currently rely on it.
> -     * The total size of the DMA buffer tells us the transfer size instead. */
>      ncq_tfs->sector_count = ((uint16_t)ncq_fis->sector_count_high << 8) |
>                                  ncq_fis->sector_count_low;
> +    ahci_populate_sglist(ad, &ncq_tfs->sglist, 0);
> +    size = ncq_tfs->sector_count * 512;

I just saw that a later patch addresses the sector_count inconsistency,
so I'm happy with this now.

--+KJYzRxRHjYqLGl5
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJViBjBAAoJEJykq7OBq3PIrCIIALnw9CTLkFG4G6ZhE290GOV2
T9pH9UxzAzEKzR4BFweQuLlyz6Rl+OreAd+acDlEA5DGjZ+ujLHIG6UHjCrkJp0U
LUB+uIKDNaaRTWJSSIgFJc0Ce4MC7jdrzhXJtdx1Ij9/CuDKq9rLuBL93JENyY4g
o+o+WDPC9/ZuDFlz6y8ooOhing3EgyAKd1fBmEMoENlVTMbdhtagit8jB/02S/51
ahYUPUDm3thNvCwkYqzwcM3KApHfxejf4tP1yAp8B83YIe2BEB/e9imefhzhU99o
vBfEVyG2ae6TmkzFpL2/Ea51O3XwPWKOrB0eXaBEbIZ9huKYMaqj4vEcJR4EJ+A=
=WHfi
-----END PGP SIGNATURE-----

--+KJYzRxRHjYqLGl5--