From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [v2 4/7] mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM Date: Mon, 22 Jun 2015 16:19:08 +0200 Message-ID: <20150622141908.GM25769@phenom.ffwll.local> References: <1434970465-12687-1-git-send-email-shobhit.kumar@intel.com> <1434970465-12687-5-git-send-email-shobhit.kumar@intel.com> <5587EB7A.5090402@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <5587EB7A.5090402@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Varka Bhadram Cc: linux-pwm , Paul Bolle , Samuel Ortiz , Alexandre Courbot , Jani Nikula , Shobhit Kumar , intel-gfx , Paul Gortmaker , linux-kernel , dri-devel , linux-gpio , bloften80@gmail.com, Povilas Staniulis , Thierry Reding , David Airlie , Daniel Vetter , Lee Jones , Linus Walleij , Chih-Wei Huang List-Id: linux-gpio@vger.kernel.org T24gTW9uLCBKdW4gMjIsIDIwMTUgYXQgMDQ6MzM6MjJQTSArMDUzMCwgVmFya2EgQmhhZHJhbSB3 cm90ZToKPiBIaSBTaG9iaGl0IEt1bWFyLAo+IAo+IE9uIDA2LzIyLzIwMTUgMDQ6MjQgUE0sIFNo b2JoaXQgS3VtYXIgd3JvdGU6Cj4gCj4gPk9uIHNvbWUgQllUIFBMYXRmb3JtIHRoZSBQV00gaXMg Y29udHJvbGxlZCB1c2luZyBDUkMgUE1JQy4gQWRkIGEgbG9va3VwCj4gPmVudHJ5IGZvciB0aGUg c2FtZSB0byBiZSB1c2VkIGJ5IHRoZSBjb25zdW1lciAoSW50ZWwgR0ZYKQo+ID4KPiA+djI6IFJl bW92ZSB0aGUgbG9va3VwIHRhYmxlIG9uIGRyaXZlciB1bmxvYWQgKFRoaWVycnkpCj4gPgo+ID52 MzogQ29ycmVjdCB0aGUgc3ViamVjdCBsaW5lIChMZWUgam9uZXMpCj4gCj4gVGhpcyBwYXJ0IHNo b3VsZCBvbmx5IGRlc2NyaWJlIHdoYXQgdGhpcyBpcyBhYm91dC4uCj4gCj4gRG9uJ3QgcHV0IHRo aXMgcGF0Y2ggY2hhbmdlIGhpc3Rvcnkgb3ZlciBoZXJlLgo+IEluY2x1ZGUgdGhpcyBjaGFuZ2Ug aGlzdG9yeSBhZnRlcgo+IC4uLgo+IFNpZ25lZC1vZmYtYnk6IEF1dGhvciA8ZW1haWw+Cj4gLS0t Cj4gCj4gPkNDOiBTYW11ZWwgT3J0aXogPHNhbWVvQGxpbnV4LmludGVsLmNvbT4KPiA+Q2M6IExp bnVzIFdhbGxlaWogPGxpbnVzLndhbGxlaWpAbGluYXJvLm9yZz4KPiA+Q2M6IEFsZXhhbmRyZSBD b3VyYm90IDxnbnVyb3VAZ21haWwuY29tPgo+ID5DYzogVGhpZXJyeSBSZWRpbmcgPHRoaWVycnku cmVkaW5nQGdtYWlsLmNvbT4KPiA+QWNrZWQtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFy by5vcmc+Cj4gPlNpZ25lZC1vZmYtYnk6IFNob2JoaXQgS3VtYXIgPHNob2JoaXQua3VtYXJAaW50 ZWwuY29tPgo+ID4tLS0KPiAKPiBIZXJlIHlvdSBhZGQgdGhpcyBjaGFuZ2UgaGlzdG9yeSBzbyB0 aGF0IGFmdGVyIGFwcGx5aW5nIHRoaXMKPiB3aWxsIG5vdCBiZSB0aGUgcGFydCBvZiB5b3VyIGNv bW1pdCBkZXNjcmlwdGlvbi4KPiAKPiBUaGlzIGNvbW1lbnQgaXMgYXBwbGljYWJsZSBmb3IgYWxs IG9mIHlvdXIgcGF0Y2hlcy4KCkl0J3MgaG9uZXN0bHkgYSBwZXItbWFpbnRhaW5lciB0aGluZyBh bmQgaGFyZCB0byB0ZWxsIHdobyB3YW50cyB3aGF0IC4uLgpQZXJzb25hbGx5IEkgZG8gd2FudCB0 byBpbmNsdWRlIHRoZSBwYXRjaCBjaGFuZ2Vsb2cgaW4gdGhlIGNvbW1pdCBtZXNzYWdlLgotRGFu aWVsCj4gCj4gCj4gLS0gCj4gQmVzdCByZWdhcmRzLAo+IFZhcmthIEJoYWRyYW0uCj4gCj4gX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZngg bWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5p ZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxv Zy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752899AbbFVOQc (ORCPT ); Mon, 22 Jun 2015 10:16:32 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:36674 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752076AbbFVOQW (ORCPT ); Mon, 22 Jun 2015 10:16:22 -0400 Date: Mon, 22 Jun 2015 16:19:08 +0200 From: Daniel Vetter To: Varka Bhadram Cc: Shobhit Kumar , linux-pwm , intel-gfx , linux-kernel , dri-devel , linux-gpio , Alexandre Courbot , Paul Bolle , Samuel Ortiz , Povilas Staniulis , Jani Nikula , Linus Walleij , Paul Gortmaker , bloften80@gmail.com, David Airlie , Chih-Wei Huang , Thierry Reding , Daniel Vetter , Lee Jones Subject: Re: [Intel-gfx] [v2 4/7] mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM Message-ID: <20150622141908.GM25769@phenom.ffwll.local> Mail-Followup-To: Varka Bhadram , Shobhit Kumar , linux-pwm , intel-gfx , linux-kernel , dri-devel , linux-gpio , Alexandre Courbot , Paul Bolle , Samuel Ortiz , Povilas Staniulis , Jani Nikula , Linus Walleij , Paul Gortmaker , bloften80@gmail.com, David Airlie , Chih-Wei Huang , Thierry Reding , Daniel Vetter , Lee Jones References: <1434970465-12687-1-git-send-email-shobhit.kumar@intel.com> <1434970465-12687-5-git-send-email-shobhit.kumar@intel.com> <5587EB7A.5090402@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5587EB7A.5090402@gmail.com> X-Operating-System: Linux phenom 4.0.0-rc3+ User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 22, 2015 at 04:33:22PM +0530, Varka Bhadram wrote: > Hi Shobhit Kumar, > > On 06/22/2015 04:24 PM, Shobhit Kumar wrote: > > >On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup > >entry for the same to be used by the consumer (Intel GFX) > > > >v2: Remove the lookup table on driver unload (Thierry) > > > >v3: Correct the subject line (Lee jones) > > This part should only describe what this is about.. > > Don't put this patch change history over here. > Include this change history after > ... > Signed-off-by: Author > --- > > >CC: Samuel Ortiz > >Cc: Linus Walleij > >Cc: Alexandre Courbot > >Cc: Thierry Reding > >Acked-by: Lee Jones > >Signed-off-by: Shobhit Kumar > >--- > > Here you add this change history so that after applying this > will not be the part of your commit description. > > This comment is applicable for all of your patches. It's honestly a per-maintainer thing and hard to tell who wants what ... Personally I do want to include the patch changelog in the commit message. -Daniel > > > -- > Best regards, > Varka Bhadram. > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/