From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932083AbbFVRxH (ORCPT ); Mon, 22 Jun 2015 13:53:07 -0400 Received: from mail-yh0-f43.google.com ([209.85.213.43]:33244 "EHLO mail-yh0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602AbbFVRw7 (ORCPT ); Mon, 22 Jun 2015 13:52:59 -0400 Date: Mon, 22 Jun 2015 13:52:55 -0400 From: Tejun Heo To: Vivek Goyal Cc: Christoph Hellwig , Mike Snitzer , dm-devel@redhat.com, Andi Kleen , linux-kernel@vger.kernel.org Subject: Re: WARNING: at fs/block_dev.c:5 when removing LV on removed device Message-ID: <20150622175255.GB3710@mtj.duckdns.org> References: <20150618165713.GB19417@two.firstfloor.org> <20150618180408.GD2321@redhat.com> <20150618180804.GC19417@two.firstfloor.org> <20150618181619.GE2321@redhat.com> <20150618190815.GA6390@redhat.com> <20150618192821.GA4027@redhat.com> <20150619064721.GA1183@lst.de> <20150622174648.GA2965@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150622174648.GA2965@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Mon, Jun 22, 2015 at 01:46:48PM -0400, Vivek Goyal wrote: > Subject: fs/block_dev.c: Warn on inode writeback failure instead of WARN_ON() > > If a block device is hot removed and later last reference to devices > is put, we try to writeback the dirty inode. But device is gone and > that writeback fails. > > Currently we do a WARN_ON() which does not seem to be the right thing. > Convert it to a ratelimited kernel warning. Yeah, looks good to me. Just one nit. ... > + if (write_inode_now(inode, true)) { > + char name[BDEVNAME_SIZE] = ""; > + pr_warn_ratelimited("VFS: Dirty inode writeback failed for block device %s.\n", bdevname(bdev, name)); This wasn't reported before either but maybe we wanna report the errno too? Also, don't we usually break the line for parameters? pr_..("long format string going over 80 col...\n", param0, param1, ...); Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: WARNING: at fs/block_dev.c:5 when removing LV on removed device Date: Mon, 22 Jun 2015 13:52:55 -0400 Message-ID: <20150622175255.GB3710@mtj.duckdns.org> References: <20150618165713.GB19417@two.firstfloor.org> <20150618180408.GD2321@redhat.com> <20150618180804.GC19417@two.firstfloor.org> <20150618181619.GE2321@redhat.com> <20150618190815.GA6390@redhat.com> <20150618192821.GA4027@redhat.com> <20150619064721.GA1183@lst.de> <20150622174648.GA2965@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150622174648.GA2965@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Vivek Goyal Cc: Christoph Hellwig , Mike Snitzer , dm-devel@redhat.com, Andi Kleen , linux-kernel@vger.kernel.org List-Id: dm-devel.ids Hello, On Mon, Jun 22, 2015 at 01:46:48PM -0400, Vivek Goyal wrote: > Subject: fs/block_dev.c: Warn on inode writeback failure instead of WARN_ON() > > If a block device is hot removed and later last reference to devices > is put, we try to writeback the dirty inode. But device is gone and > that writeback fails. > > Currently we do a WARN_ON() which does not seem to be the right thing. > Convert it to a ratelimited kernel warning. Yeah, looks good to me. Just one nit. ... > + if (write_inode_now(inode, true)) { > + char name[BDEVNAME_SIZE] = ""; > + pr_warn_ratelimited("VFS: Dirty inode writeback failed for block device %s.\n", bdevname(bdev, name)); This wasn't reported before either but maybe we wanna report the errno too? Also, don't we usually break the line for parameters? pr_..("long format string going over 80 col...\n", param0, param1, ...); Thanks. -- tejun