From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7PKi-0000JQ-OY for qemu-devel@nongnu.org; Tue, 23 Jun 2015 10:37:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7PKh-00047f-LR for qemu-devel@nongnu.org; Tue, 23 Jun 2015 10:37:52 -0400 Date: Tue, 23 Jun 2015 15:37:43 +0100 From: Stefan Hajnoczi Message-ID: <20150623143743.GE31481@stefanha-thinkpad.redhat.com> References: <1435056300-14924-1-git-send-email-dimara@arrikto.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="19uQFt6ulqmgNgg1" Content-Disposition: inline In-Reply-To: <1435056300-14924-1-git-send-email-dimara@arrikto.com> Subject: Re: [Qemu-devel] [PATCH v5 0/5] Some fixes related to scsi-generic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dimitris Aragiorgis Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org --19uQFt6ulqmgNgg1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 23, 2015 at 01:44:55PM +0300, Dimitris Aragiorgis wrote: > Hi all, >=20 > These five patches make slight changes to the way QEMU handles SCSI > generic devices to fix a number of small problems. >=20 > I am sending them against the master branch, since I don't know if they > can be considered bugfixes. >=20 > Thanks, > dimara >=20 > v5 (rebased to current master): > * First use stat() and then ioctl() in bdrv_is_sg() (Eric's comment) > * Make bdrv_is_sg() return a bool and not an int (Eric's comment) >=20 > v4 (rebased to current master): > * Avoid errno clobbering with DPRINTF + strerror() (Eric's comment) > * Use {} in #define macro even if it is not necessary (single commands) >=20 > v3 (rebased to current master): > * Avoid bit-rot in DPRINTF (adopt Eric's suggestion) > * Address Kevin's comments (DEBUG_FLOPPY, line > 80 chars, SG device) > * Mention Kevin's comment wrt disk flush in the corresponding commit >=20 > v2: > * remove duplicate check for sg inside iscsi_co_flush() > * remove DEBUG_BLOCK_PRINT in block/raw-posix.c > * use DPRINTF for debugging in block/raw-posix.c >=20 > PS: Paolo suggested to use a tracepoint inside hdev_is_sg() but I chose D= PRINTF > instead. It would make sense to add a tracepoint for bdrv_is_sg() (just l= ike > most bdrv_* commands) but this is too much for now since it just returns = the > bs->sg flag (and is not an actual driver function). If you insist I'll ch= ange > it in v3. >=20 > Dimitris Aragiorgis (5): > block: Use bdrv_is_sg() everywhere > Fix migration in case of scsi-generic > raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT > raw-posix: Use DPRINTF for DEBUG_FLOPPY > raw-posix: Introduce hdev_is_sg() >=20 > block.c | 6 ++-- > block/io.c | 3 +- > block/iscsi.c | 4 --- > block/raw-posix.c | 91 +++++++++++++++++++++++++++++++----------------= ------ > 4 files changed, 58 insertions(+), 46 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --19uQFt6ulqmgNgg1 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJViW83AAoJEJykq7OBq3PIsMkIAJJIAh+lTaMHgnlnmiREq2ro v1SmR8Xwg1gDPeRiAtsGp2yOZKlUelEKmTv9xYPfM1V5nF0UgdARQ0Tq+xklk+Mr lHDNpcFpsIFJQSy22CjF2O0h8Yqs0O8tcLJcu8ZK6uI2dvz86KPsdlaKIqYRMrM6 yMY3pBWUgznusz4keZmb5bGUJPuSoUbJv22TS2O/gxr6KcZ+Dkll6LW8IvAeJW8D Yy73cz/4Vqu5eoBWsH2+Jrmh7GJw8uwOimpWiCr25y/bczqhv7TZ0EqY/E11PTdc KnwIbE8lRcMPlL69nqqRqVovc/2K9t9MTyx61nz+lbNeZdR2tEQZPW1I0ItC1us= =Phpa -----END PGP SIGNATURE----- --19uQFt6ulqmgNgg1--