From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH 1/2] Revert "libxl: fix "xl mem-set"
 regression from 0c029c4da2"
Date: Tue, 23 Jun 2015 15:52:08 +0100
Message-ID: <20150623145208.GC28647@zion.uk.xensource.com>
References: <1435068984-9163-1-git-send-email-wei.liu2@citrix.com>
	<1435068984-9163-2-git-send-email-wei.liu2@citrix.com>
	<55898D1A0200007800088660@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=609b4a838=wei.liu2@citrix.com>)
	id 1Z7PYe-0000Eg-JJ
	for xen-devel@lists.xenproject.org; Tue, 23 Jun 2015 14:52:16 +0000
Content-Disposition: inline
In-Reply-To: <55898D1A0200007800088660@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

On Tue, Jun 23, 2015 at 03:45:14PM +0100, Jan Beulich wrote:
> >>> On 23.06.15 at 16:16, <wei.liu2@citrix.com> wrote:
> > This reverts commit f5b43e95facdc17f925cb56a8963cd4531074034.
> 
> Even if the patch having introduced the regression this fixed is
> being reverted, it's not clear to me why this change needs to be
> reverted too - it seems correct to me to use 64-bit types for the
> calculations. Or are you planning to do a more comprehensive
> adjustments to all of the types later on?
> 

I was thinking more about giving Ian (who is looking at making things
consistent) a clean state to start with. He may end up touching those
types.

This patch itself looks correct to me.

Ian, I think I will send a patch to revert the only offending commit and
fix up conflicts. Are you OK with that.

Wei.