From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932728AbbFWPHG (ORCPT <rfc822;w@1wt.eu>);
	Tue, 23 Jun 2015 11:07:06 -0400
Received: from mail.kernel.org ([198.145.29.136]:33092 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932078AbbFWPGy (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 23 Jun 2015 11:06:54 -0400
Date: Tue, 23 Jun 2015 12:06:47 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>, Jiri Olsa <jolsa@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>, Andi Kleen <ak@linux.intel.com>,
        David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Stephane Eranian <eranian@google.com>
Subject: Re: [PATCHv4 00/27] perf stat: Introduce --per-thread option
Message-ID: <20150623150647.GC3489@kernel.org>
References: <1435012588-9007-1-git-send-email-jolsa@kernel.org>
 <20150622230600.GB8510@kernel.org>
 <20150623072200.GB749@krava.redhat.com>
 <20150623140501.GB3489@kernel.org>
 <55896847.8000105@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55896847.8000105@intel.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Tue, Jun 23, 2015 at 05:08:07PM +0300, Adrian Hunter escreveu:
> On 23/06/15 17:05, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Jun 23, 2015 at 09:22:00AM +0200, Jiri Olsa escreveu:
> >> On Mon, Jun 22, 2015 at 08:06:00PM -0300, Arnaldo Carvalho de Melo wrote:
> >>> Em Tue, Jun 23, 2015 at 12:36:01AM +0200, Jiri Olsa escreveu:
> >>>> adding the possibility to display stat data per thread.
> > 
> >>>> Allowing following commands and output:
> > 
> >>>>   $ perf stat  -e cycles,instructions --per-thread -p 30190,30242
> > 
> >>> While testing Adrian's Intel PT patchkit I realised we have --per-thread
> >>> in 'record', wonder if using a long option with the exact same name but
> >>> different meanings for 'stat' and 'record'  would cause confusion...
> >  
> >> I think the name fits for both stat and record.. and both are doing different
> > 
> > For record it is vague, for stat, it seems to fit.
> > 
> > For record it really should be --mmap-per-thread, but then we start
> > getting what may seem overly long options, but then, its an oddball
> > 'record' option...
> 
> It is not just the mmap, it is also the perf context. So it is central to
> the way perf works.

Ok, so probably it should stay like that :-)

- Arnaldo