From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933200AbbFWV4a (ORCPT ); Tue, 23 Jun 2015 17:56:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34163 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754901AbbFWV4X (ORCPT ); Tue, 23 Jun 2015 17:56:23 -0400 Date: Tue, 23 Jun 2015 23:56:18 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , lkml , Adrian Hunter , Andi Kleen , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Stephane Eranian Subject: Re: [PATCH 02/27] perf tools: Add comm string into struct thread_map Message-ID: <20150623215617.GB24969@krava.brq.redhat.com> References: <1435012588-9007-1-git-send-email-jolsa@kernel.org> <1435012588-9007-3-git-send-email-jolsa@kernel.org> <20150623210158.GA11231@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150623210158.GA11231@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 23, 2015 at 06:01:58PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jun 23, 2015 at 12:36:03AM +0200, Jiri Olsa escreveu: > > Adding support to hold comm name together with pids in > > 'struct thread_map'. It will be useful for --per-thread > > option to display task pid together with task name. > > > > Getting the task name from /proc/$pid/comm. > > Do we really need to read this all the time? Or just for tools that need > this? > > Can't we have a thread_map__read_comms(map); > > That we can make this specific --per-thread option in 'stat' call? ook jirka