From: Greg KH <gregkh@linuxfoundation.org>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Olaf Hering <olaf@aepfle.de>,
"K. Y. Srinivasan" <kys@microsoft.com>,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
apw@canonical.com, jasowang@redhat.com
Subject: Re: [PATCH V2 04/10] Drivers: hv: vmbus: add special kexec handler
Date: Tue, 23 Jun 2015 20:11:02 -0700 [thread overview]
Message-ID: <20150624031102.GA21093@kroah.com> (raw)
In-Reply-To: <87381i8k3v.fsf@vitty.brq.redhat.com>
On Tue, Jun 23, 2015 at 06:28:36PM +0200, Vitaly Kuznetsov wrote:
> Olaf Hering <olaf@aepfle.de> writes:
>
> > On Thu, Jun 04, K. Y. Srinivasan wrote:
> >
> >> +++ b/arch/x86/kernel/cpu/mshyperv.c
> >> @@ -18,6 +18,9 @@
> >> #include <linux/efi.h>
> >> #include <linux/interrupt.h>
> >> #include <linux/irq.h>
> >> +#ifdef CONFIG_KEXEC
> >> +#include <linux/kexec.h>
> >> +#endif
> >
> > Is this #ifdef required?
> >
>
> No, it's not, but other parts of the same patch do (e.g. there is no
> kexec_in_progress without CONFIG_KEXEC). We can probably omit #ifdef
> here but I'm not sure it makes sense.
No #ifdef should be in a .c file if at all possible, so please remove
them all if you can. If not, then work to fix up the .h file properly
so that you can.
thanks,
greg k-h
next prev parent reply other threads:[~2015-06-24 3:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 23:25 [PATCH V2 00/10] Drivers: hv: vmbus: Enable kexec and other misc cleanup K. Y. Srinivasan
2015-06-04 23:26 ` [PATCH V2 01/10] cpu-hotplug: export cpu_hotplug_enable/cpu_hotplug_disable K. Y. Srinivasan
2015-06-04 23:26 ` [PATCH V2 02/10] Drivers: hv: vmbus: use cpu_hotplug_enable/disable K. Y. Srinivasan
2015-06-04 23:26 ` [PATCH V2 03/10] Drivers: hv: vmbus: remove hv_synic_free_cpu() call from hv_synic_cleanup() K. Y. Srinivasan
2015-06-04 23:26 ` [PATCH V2 04/10] Drivers: hv: vmbus: add special kexec handler K. Y. Srinivasan
2015-06-23 7:57 ` Olaf Hering
2015-06-23 16:28 ` Vitaly Kuznetsov
2015-06-24 3:11 ` Greg KH [this message]
2015-06-04 23:26 ` [PATCH V2 05/10] Drivers: hv: don't do hypercalls when hypercall_page is NULL K. Y. Srinivasan
2015-06-04 23:26 ` [PATCH V2 06/10] Drivers: hv: vmbus: use 'die' notification chain instead of 'panic' K. Y. Srinivasan
2015-06-25 11:37 ` Vitaly Kuznetsov
2015-06-04 23:26 ` [PATCH V2 07/10] Drivers: hv: kvp: check kzalloc return value K. Y. Srinivasan
2015-06-04 23:26 ` [PATCH V2 08/10] Drivers: hv: fcopy: dynamically allocate smsg_out in fcopy_send_data() K. Y. Srinivasan
2015-06-04 23:26 ` [PATCH V2 09/10] Drivers: hv: balloon: Enable dynamic memory protocol negotiation with Windows 10 hosts K. Y. Srinivasan
2015-06-04 23:26 ` [PATCH V2 10/10] Drivers: hv: vmbus: Permit sending of packets without payload K. Y. Srinivasan
2015-06-13 0:03 ` [PATCH V2 01/10] cpu-hotplug: export cpu_hotplug_enable/cpu_hotplug_disable Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150624031102.GA21093@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.