Re: [Qemu-devel] [Qemu-block] [PATCH v2 for-2.4 0/3] block: Improve warnings for doubly-connected drives

From: Stefan Hajnoczi <stefanha@gmail.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	qemu-block@nongnu.org, Patch Tracking <patches@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 for-2.4 0/3] block: Improve warnings for doubly-connected drives
Date: Thu, 25 Jun 2015 14:23:34 +0100	[thread overview]
Message-ID: <20150625132334.GJ4419@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <87616cvz9g.fsf@blackfin.pond.sub.org>

[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]

On Thu, Jun 25, 2015 at 12:49:31PM +0200, Markus Armbruster wrote:
> Peter Maydell <peter.maydell@linaro.org> writes:
> 
> > On 25 June 2015 at 10:26, Markus Armbruster <armbru@redhat.com> wrote:
> >> Peter Maydell <peter.maydell@linaro.org> writes:
> >>
> >>> This patchset attempts to improve the warning and error messages for
> >>> bad user command lines that attempt to connect a drive up to two
> >>> devices. The motivation here is patch #4, which changes the default
> >>> interface for the virt board to virtio. That will break some existing
> >>> command lines which forgot to specify if=none, and so I would like
> >>> us to at least diagnose that user error in a helpful way that points
> >>> the user towards adding the missing if=none.
> >
> >> With the commit message of PATCH 3 amended, series
> >> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> >
> > Thanks. Do you want to take this through a block tree or are you happy
> > for me to put it through target-arm.next?
> 
> I'm fine with target-arm.  Copying Stefan in the unlikely case he's not.

Thanks, I'm happy with this series.  Please take it through the arm
tree.

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]